[DependencyInjection] Use DOM instead of SimpleXML for namespace support #9350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicated #6147 |
guilhermeblanco
pushed a commit
to doctrine/DoctrineBundle
that referenced
this pull request
Jan 27, 2014
This allows tagging a service with an 'doctrine.orm.entity_listener' tag. These tagged services will automatically be registered with the entity listener resolver. Note: The changes to the XML fixture cannot be parsed due to a bug in the Symfony DependencyInjection component. A PR that fixes this issue can be found at symfony/symfony#9350. When that PR has been merged, all tests in this commit pass.
|
Any updates on whether this issue or issue #6147 will be merged? |
| * | ||
| * @throws InvalidArgumentException When loading of XML file returns error | ||
| */ | ||
| protected function parseFileToDOM($file) |
|
@sandermarechal Can you rebase on current master? To answer your questions:
|
|
Closing in favor of #10619 |
fabpot
added a commit
that referenced
this pull request
Apr 2, 2014
… namespace support (sandermarechal, romainneutron) This PR was merged into the 2.5-dev branch. Discussion ---------- [DependencyInjection] Use DOM instead of SimpleXML for namespace support | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #9345 | License | MIT This PR replaces #9350 Commits ------- a3c60c8 [DependencyInjection] Deprecate SimpleXMLElement 33c91f9 [DependencyInjection] Use DOM instead of SimpleXML for namespace support
BonyHanter83
added a commit
to BonyHanter83/DoctrineBundle
that referenced
this pull request
May 29, 2025
This allows tagging a service with an 'doctrine.orm.entity_listener' tag. These tagged services will automatically be registered with the entity listener resolver. Note: The changes to the XML fixture cannot be parsed due to a bug in the Symfony DependencyInjection component. A PR that fixes this issue can be found at symfony/symfony#9350. When that PR has been merged, all tests in this commit pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the XmlFileLoader use the DOM instead of SimpleXML. This allows full namespace support in XML files. Previously, the Symfony container namespace had to be the default namespace for the document. See also #9345.
Some things to discuss:
I avoided any BC breaks but I do not know if the things I avoided breaking are actually part of the API. There are two places this applies to:
Symfony\Component\DependencyInjection\SimpleXMLElementstill exists, but it is no longer used, except to maintain BC. It does not appear to be used anywhere else in Symfony itself. Maybe some userland code uses it somewhere. If this is not part of the API it could be removed.parseFilemethod still returns a SimpleXMLElement to maintain BC. I have added a new functionparseFileToDOMthat is used by the XmlFileLoader itself. If this is not part of the API we could drop that new function and haveparseFilereturn a\DOMDocumentinstead.