Feedback in cache:clear #9463
Closed
Feedback in cache:clear #9463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest displaying these additional messages only in verbose mode |
|
@stof I changed it so that the messages are only shown in verbose + I added a ":" after the default start message |
| @@ -77,9 +78,11 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| $warmupDir = substr($realCacheDir, 0, -1).'_'; | |||
|
|
|||
| if ($filesystem->exists($warmupDir)) { | |||
| $this->writelnIfVerbose($output, 'Clearing outdated warmup directory...'); | |||
There was a problem hiding this comment.
leave a space after directory
|
Better start using PHPCS before doing a pull request ^_^. I guess I will have to make a different brance to add the updates and i'll run phpcs. |
| * @param OutputInterface $output | ||
| * @return bool | ||
| */ | ||
| protected function isVerbose(OutputInterface $output){ |
|
This PR does more than changing the |
|
@ConneXNL Can you clean up this PR? |
| @@ -87,9 +90,41 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| sleep(1); // workaround for windows php rename bug | |||
| } | |||
| $filesystem->rename($warmupDir, $realCacheDir); | |||
| $this->writelnIfVerbose($output, 'Warm up completed...'); | |||
There was a problem hiding this comment.
I think you need to remove the 3 dots.
|
Closing in favor of #9966 |
fabpot
added a commit
that referenced
this pull request
Jan 7, 2014
This PR was merged into the 2.5-dev branch. Discussion ---------- added feedback to the cache:clear command simplified version of #9463 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #9463 | License | MIT | Doc PR | n/a "Especially in production it is sometimes critical to know exactly when your cache is cleared or warmed up. Currently cache:clear provides no feedback whats however. As sites get bigger, so become their cache files. Removing old cache files may sometimes even take minutes. Without any feedback from the cache:clear you do not know the current status. That's why i added more feedback to the cache:clear command that it makes it possible to see when your cache is warmed up and ready to go." Commits ------- f2261da [FrameworkBundle] simplified code a1f6411 [FrameworkBundle] added feedback in cache:clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially in production it is sometimes critical to know exactly when your cache is cleared or warmed up. Currently cache:clear provides no feedback whats however. As sites get bigger, so become their cache files. Removing old cache files may sometimes even take minutes. Without any feedback from the cache:clear you do not know the current status.
That's why i added more feedback to the cache:clear command that it makes it possible to see when your cache is warmed up and ready to go.