Introduce dedicated logger channel for deprecations #13642
Conversation
l-vo
force-pushed
the
log_deprecations_on_specific_channel
branch
from
1e91b18 to
c257763
Compare
setup/upgrade_major.rst
Outdated
| @@ -120,6 +127,48 @@ done! | |||
|
|
|||
| $ SYMFONY_DEPRECATIONS_HELPER=max[total]=999999 php ./bin/phpunit | |||
|
|
|||
| Deprecations in logs | |||
| ~~~~~~~~~~~~~~~~~~~~ | |||
| If you use the Symfony default configuration, the deprecations are also logged in a ``prod.deprecations.log`` file (prod environment): | |||
There was a problem hiding this comment.
iirc this config is not enabled now by default in the recipe
There was a problem hiding this comment.
Yes you're right, it's not enabled but present in the recipe as a comment because as a rule of thumb you only need to log deprecations in prod when you plan to migrate to the next major. IMHO it may be considered as the default configuration even if it's not always enabled.
There was a problem hiding this comment.
Understood, but maybe rewrote mentioning that this need to be enable, as by default config, it is not the case, and one can understood it is and then never find this file :)
There was a problem hiding this comment.
Oh yes sorry; I didn't make attention that the problem was in this section, thank you 👍
l-vo
force-pushed
the
log_deprecations_on_specific_channel
branch
from
c257763 to
d647d6e
Compare
|
Please review symfony/recipes#775 and update this PR accordingly if it looks good to you. |
l-vo
force-pushed
the
log_deprecations_on_specific_channel
branch
from
d647d6e to
e4a78d9
Compare
|
Laurent, thanks for this contribution. However, we're closing it as "won't merge". Why? The feature that you created is nice ... but the nicest thing of it is its great discoverability. The needed config comes automatically via Flex (for new projects or those force-updating their recipes) and the new file is easily spot in the var/logs/ directory of the application, so I don't think we need to explain this explicitly to users. Thanks for understanding! |
|
@javiereguiluz No problem, I understand 🙂 |
Close #13631