Skip to content

[Notifier] Docs for Slack options field() method #15198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Apr 7, 2021

Closes #13398

Example and image taken from symfony/symfony#36154 (comment)

cc @birkof as you provided this feature

@OskarStark OskarStark added this to the 5.2 milestone Apr 7, 2021
@OskarStark OskarStark requested a review from wouterj April 7, 2021 13:19
@carsonbot carsonbot changed the title Docs for Slack options field() method [Notifier] Docs for Slack options field() method Apr 7, 2021
@OskarStark OskarStark requested a review from fabpot April 7, 2021 13:22

The result will be something like:

.. image:: /_images/notifier/slack/field-method.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure an image is needed here ... the feature is easy to understand ... and this image will be outdated as soon as Slack makes any visual change in their app (which is common).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree but decided to add it because its not clear "how" the are displayed, because you add them in procedural way but its rendered like "table"

If you want, feel free to remove it while merging

@OskarStark
Copy link
Contributor Author

Rebased

@javiereguiluz
Copy link
Member

Thank you Oskar.

@javiereguiluz javiereguiluz merged commit 7bfd2ef into symfony:5.2 Apr 15, 2021
@OskarStark OskarStark deleted the feature/13398 branch December 7, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants