[Mailer] Add new email testing functions #18269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated target branch to 6.3 and rebased. |
OskarStark
changed the title
|
Please target 6.4 branch, thanks |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jul 9, 2023
…EmailSubjectNotContains` methods (johanadivare) This PR was merged into the 6.4 branch. Discussion ---------- [Mailer] Adds `assertEmailSubjectContains` and `assertEmailSubjectNotContains` methods > Adds assertEmailSubjectContains and assertEmailSubjectNotContains | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | No | New feature? | yes | Deprecations? | No | Tickets | Fix #49939 | License | MIT | Doc PR | symfony/symfony-docs#18269 <!-- Replace this notice by a short README for your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Commits ------- 55ba7b8 [Mailer] Add EmailSubjectContains constraint (#49939)
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Jul 9, 2023
…EmailSubjectNotContains` methods (johanadivare) This PR was merged into the 6.4 branch. Discussion ---------- [Mailer] Adds `assertEmailSubjectContains` and `assertEmailSubjectNotContains` methods > Adds assertEmailSubjectContains and assertEmailSubjectNotContains | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | No | New feature? | yes | Deprecations? | No | Tickets | Fix #49939 | License | MIT | Doc PR | symfony/symfony-docs#18269 <!-- Replace this notice by a short README for your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Commits ------- 55ba7b8f22 [Mailer] Add EmailSubjectContains constraint (#49939)
symfony-splitter
pushed a commit
to symfony/mime
that referenced
this pull request
Jul 9, 2023
…EmailSubjectNotContains` methods (johanadivare) This PR was merged into the 6.4 branch. Discussion ---------- [Mailer] Adds `assertEmailSubjectContains` and `assertEmailSubjectNotContains` methods > Adds assertEmailSubjectContains and assertEmailSubjectNotContains | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | No | New feature? | yes | Deprecations? | No | Tickets | Fix #49939 | License | MIT | Doc PR | symfony/symfony-docs#18269 <!-- Replace this notice by a short README for your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Commits ------- 55ba7b8f22 [Mailer] Add EmailSubjectContains constraint (#49939)
|
@OskarStark the code is now merged can this also be merged? |
OskarStark
approved these changes
Jul 10, 2023
|
I am on holiday, but @javiereguiluz can merge it 👍🏻 |
|
@OskarStark happy holiday 🍹 |
|
Johan, thanks for contributing this feature and the docs for it. A minor note: while merging we added the missing |
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Jul 28, 2023
…EmailSubjectNotContains` methods (johanadivare) This PR was merged into the 6.4 branch. Discussion ---------- [Mailer] Adds `assertEmailSubjectContains` and `assertEmailSubjectNotContains` methods > Adds assertEmailSubjectContains and assertEmailSubjectNotContains | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | No | New feature? | yes | Deprecations? | No | Tickets | Fix #49939 | License | MIT | Doc PR | symfony/symfony-docs#18269 <!-- Replace this notice by a short README for your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Commits ------- 55ba7b8f22 [Mailer] Add EmailSubjectContains constraint (#49939)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs symfony/symfony#50200