Skip to content

[DependencyInjection] Add defined prefix for env var processor #18464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2023
Merged

[DependencyInjection] Add defined prefix for env var processor #18464

merged 1 commit into from
Jun 29, 2023

Conversation

GaryPEGEOT
Copy link
Contributor

Fixes #18462

@carsonbot carsonbot added this to the 6.4 milestone Jun 28, 2023
@javiereguiluz javiereguiluz merged commit 8d0b4a5 into symfony:6.4 Jun 29, 2023
@javiereguiluz
Copy link
Member

Thanks Gary for contributing this!

While merging, we did some tweaks: 7f31c49

  1. We removed "defined" from the description because it's recommended to not include the worde being described in its own description (this is a bit confusing --> "defined [...] returns true if the env var is defined [...]")

  2. We renamed the env var of the example from NO_FOO to just FOO. I see the NO_COLOR example mentioned in the code PR, but using negated env vars makes the example harder to understand.

@GaryPEGEOT GaryPEGEOT deleted the patch-1 branch June 29, 2023 07:22
@GaryPEGEOT
Copy link
Contributor Author

Hi @javiereguiluz! Thanks! I think there's a small typo: #18465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

[DependencyInjection] Add defined prefix for env var processor
3 participants
@GaryPEGEOT @javiereguiluz @carsonbot