Skip to content

[Cache] Document cache:pool:clear’s new --exclude option #18595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

MatTheCat
Copy link
Contributor

@MatTheCat MatTheCat commented Jul 21, 2023

@MatTheCat MatTheCat force-pushed the cache_pool_clear_exclude branch from e799d6c to f04afe7 Compare August 26, 2023 09:06
fabpot added a commit to symfony/symfony that referenced this pull request Oct 11, 2023
…:pool:clear` command (MatTheCat)

This PR was merged into the 6.4 branch.

Discussion
----------

[FrameworkBundle] Add `--exclude` option to the `cache:pool:clear` command

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #51023
| License       | MIT
| Doc PR        | symfony/symfony-docs#18595

For now this PR just ignores excluded pools/clearers when they don’t exist or wouldn’t be cleared/run anyways. Not sure what the best DX would be 🤔

Commits
-------

21d0348 [FrameworkBundle] Add `--exclude` option to the `cache:pool:clear` command
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Oct 11, 2023
…:pool:clear` command (MatTheCat)

This PR was merged into the 6.4 branch.

Discussion
----------

[FrameworkBundle] Add `--exclude` option to the `cache:pool:clear` command

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #51023
| License       | MIT
| Doc PR        | symfony/symfony-docs#18595

For now this PR just ignores excluded pools/clearers when they don’t exist or wouldn’t be cleared/run anyways. Not sure what the best DX would be 🤔

Commits
-------

21d0348376 [FrameworkBundle] Add `--exclude` option to the `cache:pool:clear` command
@OskarStark OskarStark removed the Waiting Code Merge Docs for features pending to be merged label Oct 11, 2023
@OskarStark OskarStark modified the milestones: next, 6.4 Oct 11, 2023
@OskarStark OskarStark force-pushed the cache_pool_clear_exclude branch from f04afe7 to cc7ac50 Compare October 11, 2023 07:40
@OskarStark
Copy link
Contributor

Thanks for your work on this new feature!

@OskarStark OskarStark merged commit f505c64 into symfony:6.4 Oct 11, 2023
@MatTheCat MatTheCat deleted the cache_pool_clear_exclude branch October 11, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants