[Workflow] Allow using public properties for the marking store #18658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a note about the context: Context is not supported with property. So, if one want to use the context, they must use a public method. But the following code works: class S
{
public $marking; // Used for reading
private $context;
public function setMarking($marking, $context) { // used for setting
...
}
} |
alexandre-daubois
force-pushed
the
workflow-property
branch
from
a71406d to
4bd3c04
Compare
|
Pushed a new version, what do you think? 🙂 |
lyrixx
approved these changes
Aug 1, 2023
OskarStark
approved these changes
Aug 1, 2023
workflow.rst
Outdated
| { | ||
| $this->currentPlace = $currentPlace; | ||
| } | ||
| } | ||
|
|
||
| .. tip:: |
There was a problem hiding this comment.
I think we can use a regular paragraph here, it is too long for a tip IMHO
There was a problem hiding this comment.
You're right, updated 🙂
alexandre-daubois
force-pushed
the
workflow-property
branch
from
4bd3c04 to
1e6ec52
Compare
|
Another great combo of nice feature + nice contribution + nice review. Thank you all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #18656