[BrowserKit] Add argument $serverParameters to click() and clickLink()
#18659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Aug 1, 2023
components/browser_kit.rst
Outdated
| $client = new Client(); | ||
| $client->request('GET', '/product/123'); | ||
|
|
||
| // Works both with `click()`... |
There was a problem hiding this comment.
Suggested change
| // Works both with `click()`... | |
| // works both with `click()`... |
OskarStark
reviewed
Aug 1, 2023
components/browser_kit.rst
Outdated
| @@ -112,6 +112,28 @@ provides access to the link properties (e.g. ``$link->getMethod()``, | |||
| $link = $crawler->selectLink('Go elsewhere...')->link(); | |||
| $client->click($link); | |||
|
|
|||
| The :method:`Symfony\\Component\\BrowserKit\\AbstractBrowser::click` and | |||
| :method:`Symfony\\Component\\BrowserKit\\AbstractBrowser::clickLink` methods | |||
| can take a second, optional parameter, which is ``serverParameters``. This | |||
There was a problem hiding this comment.
Suggested change
| can take a second, optional parameter, which is ``serverParameters``. This | |
| can take optional ``serverParameters``. This |
Easier to read ?
There was a problem hiding this comment.
Yes, I rephrased! 🙂
OskarStark
approved these changes
Aug 1, 2023
alexandre-daubois
force-pushed
the
clicking-links
branch
from
8721b04 to
37b15b5
Compare
|
Thank you Alexandre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #18654