[PropertyInfo] Added documentation about camelCase assumption for getter/setter methods #18942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe a versionadded directive should be added to reflect to new behavior in 6.4 🙂 |
|
Added an versionAdded block, to explicitly mention the behavior change. @alexandre-daubois |
OskarStark
approved these changes
Oct 4, 2023
…ter/setter methods
javiereguiluz
force-pushed
the
pi_i18940
branch
from
d759f8d to
e063877
Compare
|
Jan, thanks a lot for making docs more precise and congrats on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #18940
With this PR, the documentation makes it more clear, that getters/setters for snake and camel case style properties can have a PSR-1 conform camelCase getter/setter to be considered accessible.