Skip to content

[RateLimiter] Add SlidingWindowLimiter::reserve() #18962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2023
Merged

[RateLimiter] Add SlidingWindowLimiter::reserve() #18962

merged 1 commit into from
Oct 4, 2023

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Oct 2, 2023 •
edited
Loading

Fix #18956

Doctor-RST's complaining but I'm not 100% sure how to adapt in this case, as it is a mix of deprecation and versionadded 🤔

@carsonbot carsonbot added this to the 6.4 milestone Oct 2, 2023
OskarStark
OskarStark reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can try to use a versionadded and a separate deprecated directive if that works. Otherwise you can ignore the specific rule for this file.

You can provide a follow up PR for 7.0 after this where we remove the directive and the ignored rule again.

@alexandre-daubois
Copy link
Member Author

Tried a bit of rewording here. Once merged, I'll send a PR to remove all deprecated directives added recently 🙂

@javiereguiluz
Copy link
Member

A very nice contribution with all the useful deprecation messages. Thanks a lot Alex!

@javiereguiluz javiereguiluz merged commit e2be3c3 into symfony:6.4 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@javiereguiluz javiereguiluz Awaiting requested review from javiereguiluz

Assignees
No one assigned
Labels
RateLimiter Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

[RateLimiter] Add SlidingWindowLimiter::reserve()
4 participants
@alexandre-daubois @javiereguiluz @OskarStark @carsonbot