[Console] Helpers updated to optimize the time formating #19009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Oct 10, 2023
OskarStark
reviewed
Oct 10, 2023
OskarStark
reviewed
Oct 10, 2023
OskarStark
reviewed
Oct 10, 2023
OskarStark
reviewed
Oct 10, 2023
maxbeckers
force-pushed
the
patch-19008-progress-bar-format-time
branch
from
412d2b8 to
25ab36a
Compare
|
Thanks @OskarStark for your review :) |
|
Thank you Max. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #19008. Adding documentation for the Console Helper. This optimizes the format for times like
elapsed,remainingandestimatedin the prohress bar.It formats the e.g. 172799 seconds to 1 day, 23 hrs, 59 mins, 59 secs. In the ProgressBar it is shown in a precision 2, meaning in this example 1 day, 23 hrs. The abstract
Symfony\\Component\\Console\\Helper\\Helper::formatTimeallows to add a precision to the time format. The default is1.