[HttpKernel] Add parameters kernel.runtime_mode and kernel.runtime_mode.*, all set from env var APP_RUNTIME_MODE #19067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
reviewed
Oct 21, 2023
reference/configuration/kernel.rst
Outdated
| **type**: ``boolean`` **default**: ``%env(not:default:kernel.runtime_mode.web:)%`` | ||
|
|
||
| Whether the application is running in a CLI environment. By default, | ||
| this value is the opposite of the ``kernel.runtime_mode.web`` parameter. |
There was a problem hiding this comment.
As we talk about kernel.runtime_mode.web here, what do you think to set kernel.runtime_mode.web above cli ?
There was a problem hiding this comment.
I sorted alphabetically but I think putting web above cli makes more sense indeed!
alexandre-daubois
force-pushed
the
kernel-runtime-params
branch
from
6015205 to
7f42182
Compare
…de.*, all set from env var APP_RUNTIME_MODE
alexandre-daubois
force-pushed
the
kernel-runtime-params
branch
from
7f42182 to
c3b6b2e
Compare
alamirault
approved these changes
Oct 23, 2023
OskarStark
reviewed
Oct 24, 2023
| ``kernel.runtime_mode.web`` | ||
| --------------------------- | ||
|
|
||
| **type**: ``boolean`` **default**: ``%env(bool:default::key:web:default:kernel.runtime_mode:)%`` |
There was a problem hiding this comment.
Suggested change
| **type**: ``boolean`` **default**: ``%env(bool:default::key:web:default:kernel.runtime_mode:)%`` | |
| **type**: ``boolean`` **default**: ``%env(bool:default::key:web:default:kernel.runtime_mode??)%`` |
There was a problem hiding this comment.
I took this from https://github.com/symfony/symfony/blob/6.4/src/Symfony/Component/HttpKernel/Kernel.php#L574
This new syntax was introduced here if I am right: https://github.com/symfony/symfony/pull/52079/files#r1363574735
|
Thank you Alexandre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19066