docs(website): open in playground button should not cover text #10019
Conversation
|
Thanks for the PR, @mdm317! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit cd03e39. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
mdm317
changed the title
|
Thank you for taking the time to review my code! |
This reverts commit 492c3c1.
…eeds 50 characters. This reverts commit 492c3c1.
…/mdm317/typescript-eslint into fix/button-should-not-cover-text
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10019 +/- ##
=======================================
Coverage 88.73% 88.73%
=======================================
Files 426 426
Lines 14881 14881
Branches 4327 4327
=======================================
Hits 13205 13205
Misses 1534 1534
Partials 142 142
Flags with carried forward coverage won't be shown. Click here to find out more. |
JoshuaKGoldberg
added
the
1 approval
JoshuaKGoldberg
merged commit d50b97f
into
typescript-eslint:main
PR Checklist
Overview
I increased the padding-bottom value when there was a possibility of the 'Open in Playground' button overlapping with the code text.
Before
After
