Skip to content

docs: [prefer-literal-enum-member] fix bad examples #10035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2024
Merged

docs: [prefer-literal-enum-member] fix bad examples #10035

merged 3 commits into from
Sep 27, 2024

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

Docs change - also added slight wording change in the report message

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Sep 22, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 83dbb7b
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66f18918a4c62d0008ec1595
😎 Deploy Preview https://deploy-preview-10035--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 95 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 22, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 83dbb7b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review September 22, 2024 21:59
@kirkwaiblinger kirkwaiblinger added the documentation Documentation ("docs") that needs adding/updating label Sep 23, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title docs: [prefer-literal-enum-members] fix bad examples docs: [prefer-literal-enum-member] fix bad examples Sep 23, 2024
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❇️

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 23, 2024
@kirkwaiblinger @JoshuaKGoldberg
Update packages/eslint-plugin/docs/rules/prefer-literal-enum-member.mdx
db94ed6 
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.70%. Comparing base (7b149b9) to head (83dbb7b).
Report is 15 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10035   +/-   ##
=======================================
  Coverage   88.69%   88.70%           
=======================================
  Files         426      426           
  Lines       14829    14835    +6     
  Branches     4313     4312    -1     
=======================================
+ Hits        13153    13159    +6     
  Misses       1533     1533           
  Partials      143      143
Flag Coverage Δ
unittest 88.70% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...int-plugin/src/rules/prefer-literal-enum-member.ts 92.85% <ø> (ø)

... and 3 files with indirect coverage changes

@JoshuaKGoldberg JoshuaKGoldberg merged commit ced951b into typescript-eslint:main Sep 27, 2024
62 checks passed
@kirkwaiblinger kirkwaiblinger deleted the invalid-is-not-invalid branch September 27, 2024 03:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: [prefer-literal-enum-member] Ensure invalid examples are invalid and remove TS errors as examples
2 participants
@kirkwaiblinger @JoshuaKGoldberg