-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(eslint-plugin): [prefer-literal-enum-member] allow nested bitwise operations #10037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [prefer-literal-enum-member] allow nested bitwise operations #10037
Conversation
Thanks for the PR, @kirkwaiblinger! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10037 +/- ##
==========================================
+ Coverage 85.99% 86.01% +0.02%
==========================================
Files 428 428
Lines 14912 14910 -2
Branches 4332 4327 -5
==========================================
+ Hits 12823 12825 +2
+ Misses 1744 1741 -3
+ Partials 345 344 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
977e0a1
into
typescript-eslint:main
PR Checklist
allowBitwiseExpressions
option #9166Overview
just a lil recursion.
The diff looks more complicated than it is due to the conversion to a
switch
, but I think the new version is much more readable