Skip to content

fix(eslint-plugin): [no-deprecated] max callstack exceeded when class implements itself #10040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2024
Merged

fix(eslint-plugin): [no-deprecated] max callstack exceeded when class implements itself #10040

merged 1 commit into from
Sep 29, 2024

Conversation

tarunrajput
Copy link
Contributor

PR Checklist

Overview

wraps getJsDocTags call in a try-catch

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @tarunrajput!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Sep 23, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit e5dae90
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66f5938e7c43970008103258
😎 Deploy Preview https://deploy-preview-10040--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 23, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e5dae90. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.69%. Comparing base (6dbf234) to head (a8f4396).
Report is 6 commits behind head on main.

❗ Current head a8f4396 differs from pull request most recent head e5dae90

Please upload reports for the commit e5dae90 to get more accurate results.

Files with missing lines Patch % Lines
packages/eslint-plugin/src/rules/no-deprecated.ts 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10040      +/-   ##
==========================================
- Coverage   88.74%   88.69%   -0.05%     
==========================================
  Files         427      426       -1     
  Lines       14886    14837      -49     
  Branches     4327     4312      -15     
==========================================
- Hits        13210    13160      -50     
  Misses       1534     1534              
- Partials      142      143       +1
Flag Coverage Δ
unittest 88.69% <87.50%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/src/rules/no-deprecated.ts 95.83% <87.50%> (-1.76%) ⬇️

... and 12 files with indirect coverage changes

kirkwaiblinger
kirkwaiblinger requested changes Sep 24, 2024
View reviewed changes
@kirkwaiblinger kirkwaiblinger added the awaiting response Issues waiting for a reply from the OP or another party label Sep 24, 2024
@tarunrajput tarunrajput force-pushed the getJsDocTags-max-callstack-exceeded branch 3 times, most recently from 8bfc50a to f8fe5b1 Compare September 26, 2024 16:38
@tarunrajput tarunrajput force-pushed the getJsDocTags-max-callstack-exceeded branch from f8fe5b1 to e5dae90 Compare September 26, 2024 17:02
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Sep 26, 2024
@kirkwaiblinger
Copy link
Member

awesome, thanks! 🙂

gif about infinite loop

auvred
auvred approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 7a216fe into typescript-eslint:main Sep 29, 2024
58 of 61 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

@auvred auvred auvred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-deprecated] Maximum call stack size exceeded when class implements itself
4 participants
@tarunrajput @kirkwaiblinger @auvred @JoshuaKGoldberg