Skip to content

fix(utils): update missing type information message #10043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Updates the error message to be less precise, be more accurate, and point at the docs.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 20b0b09
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66f195c9d8c9c6000884e106
😎 Deploy Preview https://deploy-preview-10043--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Sep 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 20b0b09. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review September 23, 2024 16:27
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team September 23, 2024 16:27
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base (c5dc755) to head (20b0b09).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10043      +/-   ##
==========================================
+ Coverage   88.70%   88.74%   +0.04%     
==========================================
  Files         426      426              
  Lines       14835    14872      +37     
  Branches     4312     4320       +8     
==========================================
+ Hits        13159    13198      +39     
+ Misses       1533     1532       -1     
+ Partials      143      142       -1     
Flag Coverage Δ
unittest 88.74% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ckages/utils/src/eslint-utils/getParserServices.ts 94.11% <100.00%> (ø)

... and 4 files with indirect coverage changes

@JoshuaKGoldberg JoshuaKGoldberg merged commit 53650c4 into typescript-eslint:main Sep 29, 2024
63 of 64 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Error for missing type info on file shouldn't exclusively suggest parserOptions.project
2 participants