Skip to content

docs: [no-duplicate-type-constituents] clarify relation to exactOptionalPropertyTypes #10045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 24, 2024
Merged

docs: [no-duplicate-type-constituents] clarify relation to exactOptionalPropertyTypes #10045

merged 2 commits into from
Sep 24, 2024

Conversation

justmoon
Copy link
Contributor

PR Checklist

Overview

Adds a short note explaining the difference between optional properties and optional parameters and that the rule therefore does not conflict with exactOptionalPropertyTypes.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @justmoon!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Sep 23, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 485055f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66f2eb1676087100089afb2b
😎 Deploy Preview https://deploy-preview-10045--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 23, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 485055f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (b88ea33) to head (485055f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10045   +/-   ##
=======================================
  Coverage   88.73%   88.73%           
=======================================
  Files         426      426           
  Lines       14881    14881           
  Branches     4327     4327           
=======================================
  Hits        13205    13205           
  Misses       1534     1534           
  Partials      142      142
Flag Coverage Δ
unittest 88.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

kirkwaiblinger
kirkwaiblinger requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me! Teensy touch-ups requested

@justmoon
docs: [no-duplicate-type-constituents] clarify that this rule does no…
35c09dd 
…t conflict with `exactOptionalPropertyTypes`
kirkwaiblinger
kirkwaiblinger approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks and congrats on your first PR to typescript-eslint! 🙂

FYI, this PR will stay open for a couple days still in order to give other team members a chance to review if they'd like, but otherwise you're all set 👍

celebratory gif

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 24, 2024
@Josh-Cena Josh-Cena merged commit 896c731 into typescript-eslint:main Sep 24, 2024
62 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Clarify that no-duplicate-type-constituents does not conflict with exactOptionalPropertyTypes
3 participants
@justmoon @kirkwaiblinger @Josh-Cena