Skip to content

docs: fix typo #10156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2024
Merged

docs: fix typo #10156

merged 1 commit into from
Oct 16, 2024

Conversation

rajzik
Copy link
Contributor

@rajzik rajzik commented Oct 16, 2024

PR Checklist

Overview

Hello, this is just small PR to fix typo in the documentation, I've stumbled upon this when I was trying to setup typescript eslint with eslint v9, I didn't find any issue addressing it and I didn't find any PR also.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @rajzik!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Oct 16, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 43a8bd5
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/670f9cc9c5ca4b0008ee9a06
😎 Deploy Preview https://deploy-preview-10156--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 94 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 16, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 43a8bd5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@bradzacher bradzacher changed the title fix(docs): fix import.meta.name to import.meta.dirname in the documentation docs: fix typo Oct 16, 2024
kirkwaiblinger
kirkwaiblinger approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! thanks!

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 16, 2024
@Josh-Cena Josh-Cena merged commit e2d4347 into typescript-eslint:main Oct 16, 2024
66 of 68 checks passed
@rajzik rajzik deleted the fix-typo-in-the-documentation branch October 16, 2024 20:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajzik @kirkwaiblinger @Josh-Cena