feat(eslint-plugin): [thenable-in-promise-aggregators] add rule #10163
Conversation
Also adds tests for rejected promises, calling via template literals, and `never` argument values
|
Thanks for the PR, @abrahamguo! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…henable-in-promise-aggregators
|
Hi, just leaving a quick comment, no time for a review, but now that this is being revisited I think we should use this opportunity to incorporate it into await-thenable. See #8094 (review), #8858 (comment). |
|
Marking as draft pending being changed up per #10163 (comment). cc @abrahamguo 👋 |
|
@abrahamguo @kirkwaiblinger just checking in, what should be done here? |
|
Well, #10282 was also attempting to tackle this but went stale... I'd say - if you want to continue this @abrahamguo then go for it! Otherwise if there isn't activity on this for a bit we may want to close it out as stale as well until someone has bandwidth to carry the torch. |
kirkwaiblinger
added
the
stale
|
Closing this as stale, since it hasn't had an activity in several months. But feel free to reopen if you do have time to work on it! To any other contributors coming along, if you choose to base work off of this and/or #8094 and/or #10282, please give a co-author attribution to the author(s) thereof. |
PR Checklist
Promise.all,Promise.allSettled,Promise.race) #1804Overview
Resurrection of @Tjstretchalot's work in #8094 .