feat(typescript-eslint): improve undefined extension handling #10177

mstykow · 2024-10-19T16:20:18Z

PR Checklist

Addresses an existing open issue: fixes Bug: better error handling for undefined extensions #10176
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Addresses #10176 by checking if any of the extensions are undefined and throwing a helpful error if true.

An alternative would be to filter out undefined extensions and again swallow the errors silently. But I think it's overall an improvement to actually raise an error because an undefined an extension is likely not what the user intended.

typescript-eslint · 2024-10-19T16:20:21Z

Thanks for the PR, @mstykow!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2024-10-19T16:20:33Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`988d742`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/671a50b6f16eae0008a2f919
😎 Deploy Preview	https://deploy-preview-10177--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (🟢 up 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2024-10-19T16:21:09Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 988d742. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 from NxCloud.

codecov · 2024-10-19T16:28:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.19%. Comparing base (af4743f) to head (988d742).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10177   +/-   ##
=======================================
  Coverage   86.18%   86.19%           
=======================================
  Files         430      430           
  Lines       15055    15064    +9     
  Branches     4368     4371    +3     
=======================================
+ Hits        12975    12984    +9     
  Misses       1728     1728           
  Partials      352      352

Flag	Coverage Δ
unittest	`86.19% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/typescript-eslint/src/config-helper.ts	`100.00% <100.00%> (ø)`

Addresses typescript-eslint#10176 by checking if any of the extensions are undefined and throwing a helpful error if true. Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>

JoshuaKGoldberg

A good start! 🚀

packages/typescript-eslint/src/config-helper.ts

Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>

JoshuaKGoldberg

🚀

Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>

mstykow · 2024-10-22T15:19:14Z

@JoshuaKGoldberg sorry to bug you for another review but i didn't know how to retrigger the pipeline without another commit (it was failing at a step that looked unrelated to my changes).

mstykow · 2024-10-23T19:46:31Z

@JoshuaKGoldberg friendly ping :)

JoshuaKGoldberg · 2024-10-23T20:28:34Z

@mstykow mstykow requested a review from JoshuaKGoldberg yesterday

Looks like you found the right way 🙂! Any PR that's not labeled awaiting changes is on our queue to review when we get a chance. Re-requesting review explicitly goes through an automation our end to remove the label.

JoshuaKGoldberg

LGTM! Just one suggestion that we can auto-apply before merge IMO.

packages/typescript-eslint/src/config-helper.ts

Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>

kirkwaiblinger

Looks good, thanks!

packages/typescript-eslint/src/config-helper.ts

mstykow marked this pull request as ready for review October 19, 2024 16:32

feat(typescript-eslint): improve undefined extension handling

80f6ba5

Addresses typescript-eslint#10176 by checking if any of the extensions are undefined and throwing a helpful error if true. Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>

mstykow force-pushed the feat-improve-undefined-extensions-handling branch from 015b762 to 80f6ba5 Compare October 19, 2024 16:59

Merge branch 'main' into feat-improve-undefined-extensions-handling

b91a59c

JoshuaKGoldberg requested changes Oct 22, 2024

View reviewed changes

packages/typescript-eslint/src/config-helper.ts Show resolved Hide resolved

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Oct 22, 2024

mstykow added 2 commits October 22, 2024 10:25

Merge branch 'main' into feat-improve-undefined-extensions-handling

9e3c913

feat(typescript-eslint): improve error message to include indices

75c0c84

Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>

mstykow requested a review from JoshuaKGoldberg October 22, 2024 08:52

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 22, 2024

JoshuaKGoldberg previously approved these changes Oct 22, 2024

View reviewed changes

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 22, 2024

feat(typescript-eslint): minor rewording

d3bd7aa

Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>

mstykow dismissed JoshuaKGoldberg’s stale review via d3bd7aa October 22, 2024 15:18

mstykow requested a review from JoshuaKGoldberg October 22, 2024 15:19

github-actions bot removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 22, 2024

JoshuaKGoldberg previously approved these changes Oct 23, 2024

View reviewed changes

packages/typescript-eslint/src/config-helper.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 23, 2024

kirkwaiblinger reviewed Oct 23, 2024

View reviewed changes

packages/typescript-eslint/src/config-helper.ts Outdated Show resolved Hide resolved

Merge branch 'main' into feat-improve-undefined-extensions-handling

320df05

kirkwaiblinger reviewed Oct 23, 2024

View reviewed changes

packages/typescript-eslint/src/config-helper.ts Outdated Show resolved Hide resolved

feat(typescript-eslint): add config name to error message

900f45d

Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>

mstykow dismissed JoshuaKGoldberg’s stale review via 900f45d October 23, 2024 21:37

mstykow requested review from kirkwaiblinger and JoshuaKGoldberg October 23, 2024 21:39

github-actions bot removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 23, 2024

kirkwaiblinger previously approved these changes Oct 23, 2024

View reviewed changes

packages/typescript-eslint/src/config-helper.ts Outdated Show resolved Hide resolved

quotes around what is quoted

4d6ad8b

kirkwaiblinger dismissed their stale review via 4d6ad8b October 23, 2024 22:46

mstykow added 2 commits October 24, 2024 08:47

Merge branch 'main' into feat-improve-undefined-extensions-handling

4772da3

Merge branch 'main' into feat-improve-undefined-extensions-handling

988d742

mstykow requested a review from kirkwaiblinger October 24, 2024 18:53

kirkwaiblinger approved these changes Oct 24, 2024

View reviewed changes

kirkwaiblinger merged commit ad9d3ba into typescript-eslint:main Oct 24, 2024
62 of 63 checks passed

mstykow deleted the feat-improve-undefined-extensions-handling branch October 25, 2024 07:29

github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(typescript-eslint): improve undefined extension handling #10177

feat(typescript-eslint): improve undefined extension handling #10177

Uh oh!

mstykow commented Oct 19, 2024 •

edited

Loading

Uh oh!

typescript-eslint bot commented Oct 19, 2024

Uh oh!

netlify bot commented Oct 19, 2024 •

edited

Loading

Uh oh!

nx-cloud bot commented Oct 19, 2024 •

edited

Loading

Uh oh!

codecov bot commented Oct 19, 2024 •

edited

Loading

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

mstykow commented Oct 22, 2024

Uh oh!

mstykow commented Oct 23, 2024

Uh oh!

JoshuaKGoldberg commented Oct 23, 2024

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kirkwaiblinger left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat(typescript-eslint): improve undefined extension handling #10177

feat(typescript-eslint): improve undefined extension handling #10177

Uh oh!

Conversation

mstykow commented Oct 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Oct 19, 2024

Uh oh!

netlify bot commented Oct 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Oct 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

codecov bot commented Oct 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

mstykow commented Oct 22, 2024

Uh oh!

mstykow commented Oct 23, 2024

Uh oh!

JoshuaKGoldberg commented Oct 23, 2024

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mstykow commented Oct 19, 2024 •

edited

Loading

netlify bot commented Oct 19, 2024 •

edited

Loading

nx-cloud bot commented Oct 19, 2024 •

edited

Loading

codecov bot commented Oct 19, 2024 •

edited

Loading