Skip to content

chore: throw error in generate-configs if rule is deprecated and recommended #10583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2025
Merged

chore: throw error in generate-configs if rule is deprecated and recommended #10583

merged 2 commits into from
Jan 13, 2025

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

I keep forgetting to do this quick little fixup...

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Dec 31, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ca0e35f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6774696feb8afb0008d8e00c
😎 Deploy Preview https://deploy-preview-10583--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 31, 2024 •
edited
Loading

View your CI Pipeline Execution ↗ for commit ca0e35f.

Command Status Duration Result
nx test type-utils --coverage=false ✅ Succeeded <1s View ↗
nx test visitor-keys --coverage=false ✅ Succeeded <1s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx test typescript-eslint ✅ Succeeded <1s View ↗
nx test utils ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 2s View ↗
nx test type-utils ✅ Succeeded <1s View ↗
nx run-many --target=clean ✅ Succeeded 12s View ↗
Additional runs (24) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2024-12-31 22:14:13 UTC

JoshuaKGoldberg
JoshuaKGoldberg commented Dec 31, 2024
View reviewed changes
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review January 3, 2025 04:00
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team January 3, 2025 04:00
@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 13, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit 2e5d508 into typescript-eslint:main Jan 13, 2025
65 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Error in config generation if a deprecated rule is in a (recommended|strict|stylistic) config
2 participants
@JoshuaKGoldberg @bradzacher