Skip to content

chore: enable erasableSyntaxOnly in tools #10969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2025
Merged

chore: enable erasableSyntaxOnly in tools #10969

merged 2 commits into from
Mar 20, 2025

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Mar 19, 2025 •
edited by kirkwaiblinger
Loading

Is this what you meant @kirkwaiblinger?

we can't enable it at repo level since the ast-types use enums still

PR Checklist

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @43081j!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Mar 19, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 8d3c204
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67dc58a506f5a20008cade05
😎 Deploy Preview https://deploy-preview-10969--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 19, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 8d3c204.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 5s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-20 18:12:23 UTC

@43081j 43081j changed the title cleanup(repo): enable erasableSyntaxOnly in tools chore(repo): enable erasableSyntaxOnly in tools Mar 19, 2025
@kirkwaiblinger kirkwaiblinger marked this pull request as draft March 19, 2025 09:25
@kirkwaiblinger
Copy link
Member

Is this what you meant @kirkwaiblinger?

we can't enable it at repo level since the ast-types use enums still

yep! exactly! 👍

@kirkwaiblinger kirkwaiblinger changed the title chore(repo): enable erasableSyntaxOnly in tools chore: enable erasableSyntaxOnly in tools Mar 19, 2025
@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Mar 20, 2025
@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review March 20, 2025 18:03
@kirkwaiblinger kirkwaiblinger merged commit 8fd8069 into typescript-eslint:main Mar 20, 2025
55 of 57 checks passed
@43081j 43081j deleted the eso-tools branch March 20, 2025 18:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Enable TS 5.8 erasableSyntaxOnly for our "executable" TS files
2 participants
@43081j @kirkwaiblinger