Skip to content

fix(eslint-plugin): make exported configs/plugin compatible with defineConfig() #11337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix(eslint-plugin): make exported configs/plugin compatible with defineConfig() #11337

wants to merge 3 commits into from
+800 −9

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblinger kirkwaiblinger commented Jun 24, 2025 •
edited
Loading

PR Checklist

Overview

Continuing from #11190. Learned by failure from that we'll need the included type tests to pass in order to make things work.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 24, 2025 •
edited
Loading

❌ Deploy Preview for typescript-eslint failed.

Name Link
🔨 Latest commit dcf9219
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6862fbfc4009a00008233f74

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 24, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit dcf9219.

Command Status Duration Result
nx run-many --target=build --parallel --exclude... ❌ Failed 15s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-30 21:07:03 UTC

@codecov Codecov
Copy link

codecov bot commented Jun 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.84%. Comparing base (445514a) to head (f43ae15).
Report is 26 commits behind head on main.

❗ Current head f43ae15 differs from pull request most recent head dcf9219

Please upload reports for the commit dcf9219 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11337      +/-   ##
==========================================
- Coverage   90.85%   90.84%   -0.02%     
==========================================
  Files         501      501              
  Lines       50901    50919      +18     
  Branches     8383     8386       +3     
==========================================
+ Hits        46248    46256       +8     
- Misses       4638     4648      +10     
  Partials       15       15
Flag Coverage Δ
unittest 90.84% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirkwaiblinger kirkwaiblinger mentioned this pull request Jun 30, 2025
Closed
1 task
@kirkwaiblinger
Copy link
Member Author

I've decided this is beyond me to solve. Left some thoughts in #10899 (comment)

@Copilot Copilot AI mentioned this pull request Jul 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: typescript-eslint config types are incompatible with defineConfig() types
1 participant
@kirkwaiblinger