Skip to content

chore: fix website lint task to rely on build #11377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2025
Merged

chore: fix website lint task to rely on build #11377

merged 1 commit into from
Jul 5, 2025
+4 −1

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Sets the website's build task as a dependency for its lint task.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 5, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ebbc748
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68694a49cd232c0008a1323c
😎 Deploy Preview https://deploy-preview-11377--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🔴 down 1 from production)
Accessibility: 97 (🔴 down 3 from production)
Best Practices: 100 (no change from production)
SEO: 92 (🔴 down 8 from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit ebbc748

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 9s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 5s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run integration-tests:test ✅ Succeeded 4s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 3s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx run generate-configs ✅ Succeeded 9s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-05 15:58:03 UTC

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review July 5, 2025 16:04
@JoshuaKGoldberg JoshuaKGoldberg merged commit 7ec7931 into typescript-eslint:main Jul 5, 2025
63 of 64 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the website-lint-from-build branch July 5, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Lint error from website lint not relying on build
2 participants
@JoshuaKGoldberg @JamesHenry