Skip to content

chore: add windows ci #7695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2023
Merged

chore: add windows ci #7695

merged 2 commits into from
Nov 19, 2023

Conversation

liuxingbaoyu
Copy link
Contributor

PR Checklist

Overview

Add windows ci

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @liuxingbaoyu!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Sep 27, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 967651e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65531691c8f7830007743218
😎 Deploy Preview https://deploy-preview-7695--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 90 (🔴 down 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Sep 27, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b14433c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@liuxingbaoyu liuxingbaoyu changed the title chore: Add windows ci chore: add windows ci Sep 27, 2023
StyleShit
StyleShit approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@StyleShit StyleShit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a maintainer, but LGTM

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am a maintainer and looks good to me! 😄 thanks!

JoshuaKGoldberg
JoshuaKGoldberg reviewed Sep 27, 2023
View reviewed changes
@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 27, 2023
JoshuaKGoldberg
JoshuaKGoldberg requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok yes sorry for the fake-out @liuxingbaoyu - I don't think we want to run Windows on more than one Node version. In theory there may be changes between them, but in practice I doubt they'll come up enough to justify the extra CI usage.

For context, since my review here we've continuously gone past the allotment for allowed CI jobs in parallel on the GitHub free / open source tier. Having a full extra set of runs for a different Node version would make that situation even worse. 😞

So, change request: let's just run windows-latest on the latest Node version that's also tested in ubuntu-latest.

@JoshuaKGoldberg JoshuaKGoldberg added awaiting response Issues waiting for a reply from the OP or another party and removed 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labels Oct 19, 2023
@JoshuaKGoldberg
Copy link
Member

👋 Hey @liuxingbaoyu! Just checking in, is this still something you have time for? No worries if not - I just don't want to leave it hanging.

@JoshuaKGoldberg JoshuaKGoldberg added the stale PRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period label Nov 13, 2023
@liuxingbaoyu
Copy link
Contributor Author

Thank you for the reminder! I forgot about it. :)

@JoshuaKGoldberg
Copy link
Member

Great! Whenever it's ready for re-review feel free to explicitly re-request mine through GitHub.

@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Nov 19, 2023
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 92628ae into typescript-eslint:main Nov 19, 2023
@bradzacher
Copy link
Member

This has double the number of CI jobs that gets run for our unit tests (18 -> 36) - which has a BIG impact on our CI queue times and also PR check ready times.

I wonder if we could scope windows to just the latest nodejs version?
Checking 2 node versions on windows is nice, but ultimately isn't going to catch any extra bugs except for some super rare edge-cases.

@liuxingbaoyu
Copy link
Contributor Author

https://github.com/typescript-eslint/typescript-eslint/pull/7695/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR153-R155

We already do this.🤔

@bradzacher
Copy link
Member

Oh sorry - I just saw a massive chunk of jobs spawn off and didn't actually verify things. We run so many I just assumed things incorrectly! My bad.

Oof - I wish there was an easier way to fuzz this so we didn't need so many jobs!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@StyleShit StyleShit StyleShit approved these changes

Assignees
No one assigned
Labels
stale PRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Add Windows testing to CI
4 participants
@liuxingbaoyu @JoshuaKGoldberg @bradzacher @StyleShit