chore(website): simplify playground logic #8686
Conversation
|
Thanks for the PR, @abrahamguo! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8686 +/- ##
==========================================
- Coverage 88.12% 87.23% -0.89%
==========================================
Files 411 251 -160
Lines 14287 12334 -1953
Branches 4167 3881 -286
==========================================
- Hits 12590 10760 -1830
+ Misses 1388 1305 -83
+ Partials 309 269 -40
Flags with carried forward coverage won't be shown. Click here to find out more. |
abrahamguo
changed the title
This reverts commit e31647f.
There was a problem hiding this comment.
This looks a bit cleaner to me 🙂 thanks!
I think the root intent behind #7630 was to make the Playground.tsx component a bit more split up even than this. But there's not much velocity in this area of code so I don't think it's super important that we keep iterating. This code reduction makes me happy.
Just requesting the one change on not calling the useCallback hook inline.
JoshuaKGoldberg
added
the
awaiting response
github-actions
bot
removed
the
awaiting response
PR Checklist
Overview
I took a stab at simplifying the playground code a bit...open to feedback and further discussion 👍🏻