-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(eslint-plugin): [strict-boolean-expressions] consider assertion function argument a boolean context #9074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [strict-boolean-expressions] consider assertion function argument a boolean context #9074
Conversation
Thanks for the PR, @kirkwaiblinger! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I squinted at the logic a bunch and it all seems pretty reasonable. Nice stuff. Requesting changes to add some tests just to be sure though. ✨
packages/eslint-plugin/docs/rules/strict-boolean-expressions.mdx
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/tests/rules/strict-boolean-expressions.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great! Just requesting a few touchups.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9074 +/- ##
==========================================
+ Coverage 88.37% 88.42% +0.04%
==========================================
Files 419 419
Lines 14621 14663 +42
Branches 4280 4294 +14
==========================================
+ Hits 12922 12966 +44
+ Misses 1375 1373 -2
Partials 324 324
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks excellent! I like the thoroughness of the added tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
f043f30
into
typescript-eslint:main
Thank you! 👍 |
PR Checklist
Overview
Query for call expressions, check if the function being called is an assertion function, and line up the asserted parameter with the arguments that we see.