Skip to content

fix(eslint-plugin): [strict-boolean-expressions] consider assertion function argument a boolean context #9074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

Query for call expressions, check if the function being called is an assertion function, and line up the asserted parameter with the arguments that we see.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented May 11, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7ca9f12
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/669474873f33d10007b642eb
😎 Deploy Preview https://deploy-preview-9074--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@kirkwaiblinger kirkwaiblinger changed the title [strict-boolean-expressions] Consider assertion function argument a boolean context fix(eslint-plugin): [strict-boolean-expressions] consider assertion function argument a boolean context May 11, 2024
Copy link

nx-cloud bot commented May 11, 2024

@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review May 11, 2024 00:35
@bradzacher bradzacher added the bug Something isn't working label May 28, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I squinted at the logic a bunch and it all seems pretty reasonable. Nice stuff. Requesting changes to add some tests just to be sure though. ✨

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jun 17, 2024
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Jun 21, 2024
Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! Just requesting a few touchups.

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jun 29, 2024
Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.42%. Comparing base (10f8a4d) to head (7ca9f12).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9074      +/-   ##
==========================================
+ Coverage   88.37%   88.42%   +0.04%     
==========================================
  Files         419      419              
  Lines       14621    14663      +42     
  Branches     4280     4294      +14     
==========================================
+ Hits        12922    12966      +44     
+ Misses       1375     1373       -2     
  Partials      324      324              
Flag Coverage Δ
unittest 88.42% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...int-plugin/src/rules/strict-boolean-expressions.ts 100.00% <100.00%> (+1.09%) ⬆️

@kirkwaiblinger kirkwaiblinger requested a review from auvred July 15, 2024 01:03
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Jul 15, 2024
Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent! I like the thoroughness of the added tests

@auvred auvred added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 17, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@JoshuaKGoldberg JoshuaKGoldberg merged commit f043f30 into typescript-eslint:main Jul 20, 2024
65 of 66 checks passed
@kirkwaiblinger kirkwaiblinger deleted the strict-boolean-expression-assertion-functions branch July 20, 2024 07:28
@alecmev
Copy link

alecmev commented Jul 23, 2024

Thank you! 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: [strict-boolean-expressions] Check truthiness assertion functions
5 participants