fix(eslint-plugin): [strict-boolean-expressions] consider assertion function argument a boolean context #9074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @kirkwaiblinger! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kirkwaiblinger
changed the title
JoshuaKGoldberg
requested changes
Jun 17, 2024
packages/eslint-plugin/docs/rules/strict-boolean-expressions.mdx
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/tests/rules/strict-boolean-expressions.test.ts
Outdated
Show resolved
Hide resolved
JoshuaKGoldberg
added
the
awaiting response
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
github-actions
bot
removed
the
awaiting response
auvred
requested changes
Jun 28, 2024
JoshuaKGoldberg
added
the
awaiting response
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9074 +/- ##
==========================================
+ Coverage 88.37% 88.42% +0.04%
==========================================
Files 419 419
Lines 14621 14663 +42
Branches 4280 4294 +14
==========================================
+ Hits 12922 12966 +44
+ Misses 1375 1373 -2
Partials 324 324
Flags with carried forward coverage won't be shown. Click here to find out more.
|
github-actions
bot
removed
the
awaiting response
auvred
approved these changes
Jul 17, 2024
auvred
added
the
1 approval
JoshuaKGoldberg
merged commit f043f30
into
typescript-eslint:main
65 of 66 checks passed
|
Thank you! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
Query for call expressions, check if the function being called is an assertion function, and line up the asserted parameter with the arguments that we see.