Thanks for the PR, @benmccann!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	b0e7392
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66cb416250358f00088bfb07
😎 Deploy Preview	https://deploy-preview-9878--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 95 (🔴 down 4 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b0e7392. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

Sent with 💌 from NxCloud.

Why do we have both this and #9518?

Oh, thanks for pointing that out. I hadn't seen it. I think tinyglobby is better as it has many fewer dependencies, but that PR is passing the CI whereas this one isn't. I'll check if the author is able to switch to tinyglobby in the other PR and if so perhaps we can close this one

It seems that your CI failed due to incorrect spying of glob functions. Might wanna check that out.

I just want to point out that this change added 2 new dependencies to the project and did not actually remove any included dep, if you check yarn.lock. So this feels kinda pointless change this time.
(note, I’m just a user of this plugin, so my opinions do not reflect what the maintainers may think)

I just want to point out that this change added 2 new dependencies to the project and did not actually remove any included dep, if you check yarn.lock. So this feels kinda pointless change this time.
(note, I’m just a user of this plugin, so my opinions do not reflect what the maintainers may think)

The yarn.lock isn't what's important here because it includes both dependencies and devDependencies. globby remains only for developers of this project. If you look at where it's used now it's in things like docusaurus. This PR would remove about 40% of dependencies for all consumers of typescript-eslint going from 44 down to 26

It seems that your CI failed due to incorrect spying of glob functions. Might wanna check that out.

I found the line I missed updating before. It's now correctly mocking. However, it's returning things in a different order. I think we basically have to combine our two PRs to get it working

However, it's returning things in a different order.

See #9518 (comment)

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (9f70ed1) to head (b0e7392).
Report is 3 commits behind head on main.

@@           Coverage Diff           @@
##             main    #9878   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files         407      407           
  Lines       13941    13944    +3     
  Branches     4071     4071           
=======================================
+ Hits        12273    12276    +3     
  Misses       1355     1355           
  Partials      313      313           

As per #9453 (comment) we're going to go with #9518 for now.
We may revisit this in future and switch from fast-glob to tinyglobby.