Skip to content

fix(useCssVar): avoid untarget style pollution #4841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

fix(useCssVar): avoid untarget style pollution #4841

wants to merge 12 commits into from

Conversation

ArthurDarkstone
Copy link
Contributor

@ArthurDarkstone ArthurDarkstone commented Jun 27, 2025 •
edited by ilyaliao
Loading

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

Additional context

fix: #4828

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 27, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jun 27, 2025
@ilyaliao ilyaliao changed the title Fix useCssVar untarget style pollution fix(useCssVar): avoid untarget style pollution Jun 28, 2025
ilyaliao
ilyaliao previously approved these changes Jun 28, 2025
View reviewed changes
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 28, 2025
@43081j
Copy link
Collaborator

43081j commented Jun 28, 2025

does this mean there's no way to get back to the fallback?

maybe we should just treat null and undefined differently

if the target is null, someone must've explicitly set it to that or failed to find the element. if it is undefined, they just didn't set a target

so we can just fallback when it is undefined?

@ilyaliao
Copy link
Member

ilyaliao commented Jun 29, 2025 •
edited
Loading

Yes, another issue is that when the target gets replaced, the new one might not have been rendered yet.
(Also, I don’t think we should cause side effects inside a computed)

OrbisK
OrbisK reviewed Jun 30, 2025
View reviewed changes
@ArthurDarkstone
Copy link
Contributor Author

What if v-if is false at first?

then element = null, then targetHadValue = false use root?

v-if="false" case:
https://playground.vueuse.org/#eNp9U01v2zAM/SucLk6BJN6wnQJ36Fb0sB22oel60sVz6EStLBmi7GYI8t9HSbXjFGtv/Hh8fCSlg/jStsu+Q7ESBVVOtR4IfdeCLs32UgpPUnyWRjWtdR4O0BFeE92XDo5QO9tAdsXVHM0r6zCbIGlXam2fbrGeh6o7bFpdemR/LOVKrpCmsoY8VLZpQ/byBXyWhUx2MUVq6xIuiZlli0UMZvOBZg4HaQCUUV6V+r7UHa4gc7jhjscJl6L1zj4x2UnvrC41IWOKPK2EF8COf5bEHkCxUX002PzTeW8NXFVaVY+8s5HyXbJ4gzEFDRZ5Ag+lJ5bkQKVLIuZo/OLDeymgX6h6pGTfYXDDjOyQ/6sxujz6CnpexPMeLuLVEi/AumTlCB73fmyWp9Znzc/5XqX7TQjOWr4DEYNeUp7bg1Xkk/1JI+b8tPgCtdouH8gafn/xXmk2pdH9bL3iC0mxSpcMuXih7zHmXYfzIV7tsHr8T/yB9iEmxS+HhK5HKcacL90WfUrfrH+E3ZySjd10mtFvJG+RrO6CxgT72pkNy57gotpv8T8os72jm71HQ8NQQWhAHiNeCv4M12+MfpL7cfkp1vE7Fsd/HnM82Q==

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrbisK OrbisK OrbisK left review comments

@ilyaliao ilyaliao ilyaliao left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG | useCssVar | The css variables are added to document.documentElement when the initial value of target is undefined
4 participants
@ArthurDarkstone @43081j @ilyaliao @OrbisK