Skip to content

ci: use node v24 #4842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ci: use node v24 #4842

wants to merge 2 commits into from

Conversation

iiio2
Copy link
Contributor

@iiio2 iiio2 commented Jun 27, 2025

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

Additional context

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 27, 2025
@ilyaliao ilyaliao requested a review from antfu June 28, 2025 08:26
@43081j
Copy link
Collaborator

43081j commented Jun 28, 2025

@iiio2 strangely the tests seem to fail

any idea whats up there? mostly useFetch

@43081j
Copy link
Collaborator

43081j commented Jun 29, 2025

im not sure whats broken but the useFetch tests seem pretty wrong now that i've taken a closer look at them

most importantly - they run in node, and even have a condition to only run on node >18. but useFetch will never run in node, will it? won't every user in real life be running this in a browser?

but we can't just move them to browser tests because they spin up all sorts of node-specific server stuff to actually respond to the fetch calls. we should probably just be mocking fetch...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu Awaiting requested review from antfu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iiio2 @43081j @antfu