[Form] Remove BC layer from ResizeFormListener
#60952
Open
+8
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OskarStark
commented
Jun 29, 2025
OskarStark
commented
| Q | A |
|---|---|
| Branch? | 8.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | -- |
| License | MIT |
OskarStark
force-pushed
the
remove-resizeformlistener-bc-layer
branch
from
54b564b to
237d06d
Compare
xabbuh
requested changes
Jun 30, 2025
Done |
OskarStark
force-pushed
the
remove-resizeformlistener-bc-layer
branch
from
237d06d to
45281ac
Compare
|
The "Verify Packages" failure also looks related. :) |
OskarStark
commented
Jun 30, 2025
src/Symfony/Component/Form/Extension/Core/EventListener/ResizeFormListener.php
Show resolved
Hide resolved
OskarStark
force-pushed
the
remove-resizeformlistener-bc-layer
branch
from
45281ac to
f8ddd36
Compare
Indeed, done, thanks |
stof
approved these changes
Jun 30, 2025
yceruto
approved these changes
Jun 30, 2025
- Remove deprecated preSetData() method - Remove BC properties overridden and usePreSetData - Update postSetData() to only accept PostSetDataEvent parameter - Fix tests to use PostSetDataEvent instead of FormEvent - Remove tests for deprecated preSetData method (testPreSetDataResizesForm, testPreSetDataRequiresArrayOrTraversable, testPreSetDataDealsWithNullData) - Remove symfony/deprecation-contracts dependency as it's no longer needed - Add CHANGELOG and UPGRADE-8.0.md entries
OskarStark
force-pushed
the
remove-resizeformlistener-bc-layer
branch
from
f8ddd36 to
4afda18
Compare
OskarStark
commented
Jul 1, 2025
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.