feat: implement basic archive ui to make archiving failed versions easy #10182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More work is needed... this is just the MVP
Emyrk
force-pushed
the
stevenmasley/archive_ui
branch
from
a7129f0 to
2a1f3ee
Compare
| onError: (error) => { | ||
| displayError(getErrorMessage(error, "Failed to archive version")); | ||
| }, | ||
| }); |
There was a problem hiding this comment.
All the queries and mutations we are putting into the api/queries modules
There was a problem hiding this comment.
I just copy pasted what was above, and changed it to archive vs promote.
There was a problem hiding this comment.
Can we refactor this in another PR?
I think I need to learn this new style of pushing the mutation to an external package. I thought it would be a copy paste, but it is not.
The current code is async and works on useState and callbacks, but it seems the new way is to await?
site/src/pages/TemplatePage/TemplateVersionsPage/VersionRow.tsx
Outdated
Show resolved
Hide resolved
BrunoQuaresma
approved these changes
Oct 11, 2023
|
@BrunoQuaresma I will fix your suggestions. also feel free to make any changes you'd like to. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recognize the "reload" is not good, and this does not expose all functionality such as "unarchive". I will defer some styling and that for now to the FE team.
The CLI has all the functionality needed, the UI has the easy ability to hide "failed" versions, which is the primary reason for the feature.
Peek.2023-10-10.11-26.webm