Skip to content

fix: increase default staleTime for paginated data #11041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 5, 2023
Merged

fix: increase default staleTime for paginated data #11041

merged 6 commits into from
Dec 5, 2023

Conversation

Parkreiner
Copy link
Member

@Parkreiner Parkreiner commented Dec 5, 2023 •
edited
Loading

Closes #11016 in tandem with #11040

Changes made

  • Increases the staleTime value for usePaginatedQuery so that data only gets auto-invalidated after 1 minute passes (instead of it happening immediately)
    • Could have applied this change to the entire app, but that would have required a lot more testing
    • We probably should increase the app's staleTime at some point, but making a more local change was the least aggressive way to wrangle the usePaginatedQuery hook for now
    • Data can still be invalidated manually when need be with no issue, though

@Parkreiner Parkreiner self-assigned this Dec 5, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Dec 5, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@Parkreiner Parkreiner enabled auto-merge (squash) December 5, 2023 14:40
@Parkreiner Parkreiner merged commit fab343a into main Dec 5, 2023
@Parkreiner Parkreiner deleted the mes/pag-fix-2 branch December 5, 2023 14:41
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@Parkreiner Parkreiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit log page makes unncessary API requests
1 participant
@Parkreiner