chore: add built in organization roles to match site #13938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added org user admin, org template admin, and org auditor
Emyrk
commented
Jul 19, 2024
Comment on lines
+453
to
+457
| Site: Permissions(map[string][]policy.Action{ | ||
| // To assign organization members, we need to be able to read | ||
| // users at the site wide to know they exist. | ||
| ResourceUser.Type: {policy.ActionRead}, | ||
| }), |
There was a problem hiding this comment.
This needs to be fixed by only needing the org member read permission. But ExtractUser is currently used in organization routes, where an org member should probably be sufficient.
Comment on lines
+391
to
+395
| Site: Permissions(map[string][]policy.Action{ | ||
| // To assign organization members, we need to be able to read | ||
| // users at the site wide to know they exist. | ||
| ResourceUser.Type: {policy.ActionRead}, | ||
| }), |
There was a problem hiding this comment.
This is unfortunate, but to add a user to an org, we need to know that user exists.
f0ssel
approved these changes
Jul 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added org user admin, org template admin, and org auditor
Closes #13763