chore: add /groups endpoint to filter by organization and/or member
#14260
Conversation
Emyrk
changed the title
organization and/or member
Emyrk
force-pushed
the
stevenmasley/remove_extra_groups_query
branch
from
813a4da to
190bd90
Compare
|
✅ Meticulous spotted zero visual differences across 1412 screens tested: view results. Expected differences? Click here. Last updated for commit ee3c8e4. This comment will update as new commits are pushed. |
| source | ||
| ) | ||
| SELECT | ||
| gen_random_uuid(), | ||
| group_name, | ||
| @organization_id, | ||
| @source | ||
| gen_random_uuid(), | ||
| group_name, | ||
| @organization_id, | ||
| @source | ||
| FROM | ||
| UNNEST(@group_names :: text[]) AS group_name | ||
| UNNEST(@group_names :: text[]) AS group_name |
There was a problem hiding this comment.
SQL spacing is so annoying. I wish there was some nice formatter that just worked.
| // UUIDorName will parse a string as a UUID, if it fails, it uses the "fetchByName" | ||
| // function to return a UUID based on the value as a string. | ||
| // This is useful when fetching something like an organization by ID or by name. | ||
| func (p *QueryParamParser) UUIDorName(vals url.Values, def uuid.UUID, queryParam string, fetchByName func(name string) (uuid.UUID, error)) uuid.UUID { |
There was a problem hiding this comment.
nit: having the query param 3rd here feels off to me personally, I'd expect the order values, query param, uuid, fetchByName.
There was a problem hiding this comment.
I see that, unfortunately the other functions all do default, queryParam so it felt odd to switch the order of those two.
I agree with you though, I think all the functions could be reordered, but don't want to do that refactor here.
Closes #14249