fix: remove unique constraint on OAuth2 provider app names #18669
+7
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 30, 2025
This was referenced Jun 30, 2025
ThomasK33
changed the title
ThomasK33
force-pushed
the
thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance
branch
from
4efb07a to
8a3f7a9
Compare
ThomasK33
force-pushed
the
thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows
branch
from
58b076d to
88f01e4
Compare
|
@ThomasK33 tests seem unhappy 😔 |
Yeah, I forgot to update them. On it. |
ThomasK33
force-pushed
the
thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance
branch
from
8a3f7a9 to
e7d56c2
Compare
ThomasK33
force-pushed
the
thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows
branch
from
88f01e4 to
0d042a4
Compare
ThomasK33
force-pushed
the
thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance
branch
from
e7d56c2 to
10701da
Compare
ThomasK33
force-pushed
the
thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows
branch
from
0d042a4 to
f4614fd
Compare
ThomasK33
force-pushed
the
thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance
branch
2 times, most recently
from
a2607a8 to
990f706
Compare
ThomasK33
force-pushed
the
thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows
branch
from
f4614fd to
5943be1
Compare
ThomasK33
force-pushed
the
thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance
branch
from
990f706 to
95c0496
Compare
ThomasK33
force-pushed
the
thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows
branch
from
5943be1 to
2e85437
Compare
ThomasK33
force-pushed
the
thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows
branch
from
2e85437 to
aa379a5
Compare
…liance Change-Id: Iae7a1a06546fbc8de541a52e291f8a4510d57e8a Signed-off-by: Thomas Kosiewski <tk@coder.com>
ThomasK33
force-pushed
the
thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance
branch
from
95c0496 to
b17d907
Compare
johnstcn
approved these changes
Jul 1, 2025
Comment on lines
-138
to
-146
| // Generate an application for testing name conflicts. | ||
| req := codersdk.PostOAuth2ProviderAppRequest{ | ||
| Name: "taken", | ||
| CallbackURL: "http://coder.com", | ||
| } | ||
| //nolint:gocritic // OAauth2 app management requires owner permission. | ||
| _, err := client.PostOAuth2ProviderApp(ctx, req) | ||
| require.NoError(t, err) | ||
|
|
There was a problem hiding this comment.
We should validate that multiple OAuth2 apps can have the same name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unique constraint on OAuth2 provider app names
This PR removes the unique constraint on the
namefield in theoauth2_provider_appstable to comply with RFC 7591, which only requires unique client IDs, not unique client names.Changes include:
Change-Id: Iae7a1a06546fbc8de541a52e291f8a4510d57e8a
Signed-off-by: Thomas Kosiewski tk@coder.com