feat: add MCP HTTP transport endpoint with authentication #18670
+1,686
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 30, 2025
ThomasK33
changed the title
ThomasK33
force-pushed
the
thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance
branch
from
4efb07a to
8a3f7a9
Compare
ThomasK33
force-pushed
the
thomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration
branch
from
4d966b2 to
4ffc58e
Compare
ThomasK33
force-pushed
the
thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance
branch
from
8a3f7a9 to
e7d56c2
Compare
ThomasK33
force-pushed
the
thomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration
branch
from
4ffc58e to
23804bb
Compare
ThomasK33
force-pushed
the
thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance
branch
from
e7d56c2 to
10701da
Compare
ThomasK33
force-pushed
the
thomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration
branch
from
23804bb to
06d9b57
Compare
ThomasK33
force-pushed
the
thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance
branch
from
10701da to
a2607a8
Compare
ThomasK33
force-pushed
the
thomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration
branch
from
06d9b57 to
cee654a
Compare
ThomasK33
force-pushed
the
thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance
branch
from
a2607a8 to
990f706
Compare
ThomasK33
force-pushed
the
thomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration
branch
2 times, most recently
from
8cb9d74 to
3e540ef
Compare
ThomasK33
force-pushed
the
thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance
branch
from
990f706 to
95c0496
Compare
ThomasK33
force-pushed
the
thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance
branch
from
95c0496 to
b17d907
Compare
- Add MCP HTTP server with streamable transport support - Integrate with existing toolsdk for Coder workspace operations - Add comprehensive E2E tests with OAuth2 bearer token support - Register MCP endpoint at /api/experimental/mcp/http with authentication - Support RFC 6750 Bearer token authentication for MCP clients Change-Id: Ib9024569ae452729908797c42155006aa04330af Signed-off-by: Thomas Kosiewski <tk@coder.com>
ThomasK33
force-pushed
the
thomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration
branch
from
3e540ef to
0447dc7
Compare
johnstcn
requested changes
Jul 1, 2025
There was a problem hiding this comment.
This appears to still be running inside coderd. I don't think it should exit experimental until it can be run independently of Coder. Could this simply be a separate server subcommand instead? This will allow admins to deploy it separately depending on their threat model. Right now, this just auto-enables it for all deployments regardless of whether you want it or not.
| func mustParseURL(rawURL string) *url.URL { | ||
| u, err := url.Parse(rawURL) | ||
| if err != nil { | ||
| panic(fmt.Sprintf("Failed to parse URL %q: %v", rawURL, err)) |
There was a problem hiding this comment.
Wouldn't require.NoError here make more sense?
There was a problem hiding this comment.
Maybe. (?)
I'm not opposed to making this a mustParseURL(t *testing.T, ..., but usually most helper functions that mustDoSomething panic on an error.
There was a problem hiding this comment.
I'm down for whatever returns the most meaningful output 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MCP HTTP server with streamable transport support
Change-Id: Ib9024569ae452729908797c42155006aa04330af
Signed-off-by: Thomas Kosiewski tk@coder.com