Skip to content

example: docker: support Windows hosts #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2022
Merged

example: docker: support Windows hosts #1880

merged 2 commits into from
May 28, 2022

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented May 27, 2022

This adds support for using the Docker example on WIndows, as long as Docker is installed, of course. Works for both WSL and Hyper-V versions of Docker Desktop.

See: hashicorp/terraform-provider-docker#180 (comment).

Alternatives:

Closes #1789

@bpmct bpmct requested review from jsjoeio and kylecarbs May 27, 2022 22:18
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find and fix!

@greyscaled greyscaled changed the title template: docker: support Windows hosts example: docker: support Windows hosts May 27, 2022
@bpmct bpmct enabled auto-merge (squash) May 28, 2022 01:00
@bpmct bpmct merged commit 7ad68ca into main May 28, 2022
@bpmct bpmct deleted the bpmct/fix-docker-windows branch May 28, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Docker examples on Windows "protocol not available"
2 participants