feat: show queue position of pending workspace build #8244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Jun 28, 2023
| contact your administrator for assistance. | ||
| </div> | ||
| <div> | ||
| Position in queue:{" "} |
There was a problem hiding this comment.
Is the {" "} necessary here? I would imagine the newline becomes a space but maybe not in React-land.
There was a problem hiding this comment.
It seems to be necessary. Otherwise, it's merged together: Position in queue:3 (no space).
site/src/components/WorkspaceStatusBadge/WorkspaceStatusBadge.tsx
Outdated
Show resolved
Hide resolved
| if (provisionerJob === undefined || provisionerJob.queue_size === 0) { | ||
| return t("workspaceStatus.pending", { ns: "common" }) | ||
| } | ||
| return "Position in queue: " + provisionerJob.queue_position |
There was a problem hiding this comment.
I skipped this on purpose, as we are not going to implement translations. I learnt some time ago
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6465
This PR exposes the queue position of a pending workspace build. It implements the action items from the Build visibility RFC.