-
Notifications
You must be signed in to change notification settings - Fork 937
feat: show queue position of pending workspace build #8244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Just a few minor comments and suggestions.
contact your administrator for assistance. | ||
</div> | ||
<div> | ||
Position in queue:{" "} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the {" "}
necessary here? I would imagine the newline becomes a space but maybe not in React-land.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be necessary. Otherwise, it's merged together: Position in queue:3
(no space).
site/src/components/WorkspaceStatusBadge/WorkspaceStatusBadge.tsx
Outdated
Show resolved
Hide resolved
if (provisionerJob === undefined || provisionerJob.queue_size === 0) { | ||
return t("workspaceStatus.pending", { ns: "common" }) | ||
} | ||
return "Position in queue: " + provisionerJob.queue_position |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use t
here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skipped this on purpose, as we are not going to implement translations. I learnt some time ago
Fixes: #6465
This PR exposes the queue position of a pending workspace build. It implements the action items from the Build visibility RFC.