Skip to content

feat: add activity bumping to template scheduling #9040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 22, 2023
Merged

feat: add activity bumping to template scheduling #9040

merged 6 commits into from
Aug 22, 2023

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Aug 11, 2023

This PR adds the ability to update the last_used_at and/or locked_at fields for template workspaces when updating the template scheduling form. This is to prevent updates to the inactivity_ttl or locked_ttl fields on a template having a potentially unintended effect for existing workspaces.

e.g. You update the locked_ttl field to retain locked workspaces for 1 day from 10 days, inadvertently deleting workspaces that have already been locked for more than 1 day.

@sreya sreya requested a review from BrunoQuaresma August 11, 2023 04:00
@sreya sreya marked this pull request as ready for review August 14, 2023 19:26
@sreya sreya force-pushed the jon/wsbump branch 2 times, most recently from d3fda4e to c1da2e0 Compare August 14, 2023 19:31
@sreya sreya merged commit 6e41cd1 into main Aug 22, 2023
@sreya sreya deleted the jon/wsbump branch August 22, 2023 20:15
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants