Enable the IR checker post optimizer with RT longs #5077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzm0
force-pushed
the
ir-check-long
branch
2 times, most recently
from
c527a00 to
256a2f4
Compare
|
It looks like the change in subtyping checks (3rd commit) causes long literals to become allocated as RT long: $c_jl_Math$.prototype.multiplyExact__J__J__J = (function(a, b) {
var ahi = b.RTLong__f_hi;
if (((ahi === 0) ? (b.RTLong__f_lo !== 0) : (ahi > 0))) {
- var this$1 = $m_RTLong$();
- var lo = this$1.divideImpl__I__I__I__I__I((-1), 2147483647, b.RTLong__f_lo, b.RTLong__f_hi);
- var hi = this$1.RTLong$__f_org$scalajs$linker$runtime$RuntimeLong$$hiReturn;
+ var this$1 = new $c_RTLong((-1), 2147483647);
+ var this$2 = $m_RTLong$();
+ var lo = this$2.divideImpl__I__I__I__I__I(this$1.RTLong__f_lo, this$1.RTLong__f_hi, b.RTLong__f_lo, b.RTLong__f_hi);
+ var hi = this$2.RTLong$__f_org$scalajs$linker$runtime$RuntimeLong$$hiReturn;
var ahi$1 = a.RTLong__f_hi;
if (((ahi$1 === hi) ? (((-2147483648) ^ a.RTLong__f_lo) > ((-2147483648) ^ lo)) : (ahi$1 > hi))) {
var overflow = true;I'm trying to identify where the "offending" subtyping check is in the optimizer. |
|
I have not gotten to a conclusion here yet. But it seems the issue is due to casts inserted on the receiver when inlining method calls: We need these when, say, calling |
|
I have managed to fix the execution tests: the claim that we never do an I have not figured out yet what causes long literals to be stack allocated rather than inlined like before. |
gzm0
added a commit
to gzm0/scala-js
that referenced
this pull request
Jun 1, 2025
Discovered while working on scala-js#5077. This allows to remove unnecessary unboxes and unlocks more inlining.
Going foward, we want to cast pre transformed records (for longs). So
we need PreTransCast to avoid eagerly transforming the record.
As a nice side effect, we see better receiver variable allocation:
```diff
--- baseline.js 2025-06-07 09:56:18.846667192 +0200
+++ pre-trans-cast.js 2025-06-08 14:20:11.704783221 +0200
@@ -17540,8 +17540,7 @@
var logException = ((!$n($thiz.Lorg_scalajs_junit_Reporter__f_settings).Lorg_scalajs_junit_RunSettings__f_notLogExceptionClass) && ($n($thiz.Lorg_scalajs_junit_Reporter__f_settings).Lorg_scalajs_junit_RunSettings__f_logAssert || (!(t instanceof $c_jl_AssertionError))));
if (logException) {
var this$1 = $n(t);
- var this$2 = $objectGetClass(this$1);
- var fmtName = ($p_Lorg_scalajs_junit_Reporter__formatClass__T__T__T($thiz, this$2.data.name, "\u001b[31m") + ": ");
+ var fmtName = ($p_Lorg_scalajs_junit_Reporter__formatClass__T__T__T($thiz, $objectClassName(this$1), "\u001b[31m") + ": ");
} else {
var fmtName = "";
}
```
Since we have PreTransCast now, we do not need to push down casts to preserve aliases. No diff. Related: 6fd9322
This will become relevant, as we introduce casts for RuntimeLong. No diff (TODO: re-check)
This allows us to enable the IRChecker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two commits are not strictly necessary. However, I felt they significantly help understanding of what the optimizer is doing.