Allow Travis CI to build on PHP 7.4 #32289

phansys · 2019-06-29T23:11:25Z

Q	A
Branch?	3.4
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	n/a

Tobion · 2019-06-29T23:13:12Z

This needs to target 3.4

phansys · 2019-06-29T23:26:31Z

This needs to target 3.4

Target updated 👍

nicolas-grekas

I'm putting this on hold because we usually don't add "allowed_job" lines: this would consume a job for every PR+merge, while they are quite precious.
Of course, once it's green and reasonably stable, we'll merge as a regular job.
Then, we'll want to rotate all jobs: deps=low should be the one running 7.4, deps=high 7.3, etc.
Could you please have a look to make this work?

phansys · 2019-06-30T21:17:12Z

Of course!
I'll try to check how to fix the job, since the issue seems to be APC related (ref.).

phansys · 2019-06-30T21:35:21Z

The tests are running now. The failures are caused by unsilenced deprecation notices.

nicolas-grekas · 2019-06-30T21:46:18Z

Function ReflectionType::__toString() is deprecated

this happened to Twig today too and was fixed by removing the use of some mocks
Not sure we can do it for Symfony.
Instead, we could try making the phpunit script (see repo root) use phpunit 8.2 on PHP 7.4.

nicolas-grekas · 2019-06-30T22:01:11Z

We should mute this specific deprecation in the bridge I think, because many projects will be affected. /cc @greg0ire

phpunit

greg0ire · 2019-07-01T07:50:34Z

We should mute this specific deprecation in the bridge I think, because many projects will be affected. /cc @greg0ire

🤔 maybe we could add a new deprecation group called muted and have a way to display them anyway, just in case? SYMFONY_DEPRECATIONS_HELPER="scream=true"? I wonder if this use case will happen a lot.

phansys · 2019-07-01T14:59:25Z

PHPUnit ^8.0 seems to require some missing return declarations at inherited methods, by instance:

Declaration of Symfony\Bundle\WebProfilerBundle\Tests\DependencyInjection\WebProfilerExtensionTest::setUp() must be compatible with PHPUnit\Framework\TestCase::setUp(): void

Given that, I think this version bump can't be done in a minor release. Please, let me know how to proceed if you have elaborated some concerns about this.

greg0ire · 2019-07-06T07:49:56Z

Given that, I think this version bump can't be done in a minor release.

You might be able to, but it will take some black magic:

symfony/src/Symfony/Bridge/PhpUnit/CoverageListener.php

Lines 14 to 20 in 6811aaa

    
           if (class_exists('PHPUnit_Runner_Version') && version_compare(\PHPUnit_Runner_Version::id(), '6.0.0', '<')) { 
        
               class_alias('Symfony\Bridge\PhpUnit\Legacy\CoverageListenerForV5', 'Symfony\Bridge\PhpUnit\CoverageListener'); 
        
           } elseif (version_compare(\PHPUnit\Runner\Version::id(), '7.0.0', '<')) { 
        
               class_alias('Symfony\Bridge\PhpUnit\Legacy\CoverageListenerForV6', 'Symfony\Bridge\PhpUnit\CoverageListener'); 
        
           } else { 
        
               class_alias('Symfony\Bridge\PhpUnit\Legacy\CoverageListenerForV7', 'Symfony\Bridge\PhpUnit\CoverageListener'); 
        
           }

greg0ire · 2019-07-06T08:23:03Z

I built a thing! I'm a bit unsure if this should be considered bugfix or feature, and what version of the phpunit bridge is used to test 3.4 . Please advise.

nicolas-grekas · 2019-07-08T12:39:25Z

@greg0ire sorry I should have been more specific: we should mute based on the message AND the stack trace: only deprecations from phpunit should be muted.

greg0ire · 2019-07-08T16:04:26Z

Oh ok it makes a lot more sense now ^^

greg0ire · 2019-07-08T18:18:29Z

I ended up picking 4.3, see link above.

@nicolas-grekas

…greg0ire) This PR was merged into the 4.3 branch. Discussion ---------- [PHPUnitBridge] Mute deprecations triggered from phpunit | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Request by @nicolas-grekas here: #32289 (comment) Commits ------- a4ab13d Mute deprecations triggered from phpunit

phansys · 2019-07-18T14:53:51Z

@greg0ire, here is a sample build on 4.3 after the merge of #32443: https://travis-ci.org/phansys/symfony/jobs/560515287.

nicolas-grekas · 2019-07-18T16:13:03Z

Needs egulias/EmailValidator#203 now

greg0ire · 2019-07-19T05:42:07Z

@greg0ire, here is a sample build on 4.3 after the merge of #32443: https://travis-ci.org/phansys/symfony/jobs/560515287.

Oh wow my fix works already? I thought it would be necessary to have it land in the vendor directory, which implies a new release… plus you are targetting 3.4, so I really don't get it 🤔 Anyway, cool :)

nicolas-grekas · 2019-07-19T21:30:45Z

Next step unlocked. We could replace all setup/teardown methods by before/after ones, with the same as annotations.

nicolas-grekas

I'm now merging this on 3.4 only so that we can have some visibility on PHP7.4 support without consuming too many jobs.

nicolas-grekas · 2019-07-31T17:02:57Z

Thank you @phansys.

This PR was merged into the 3.4 branch. Discussion ---------- Allow Travis CI to build on PHP 7.4 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 1ca61d3 Allow Travis CI to build on PHP 7.4

carsonbot added the Status: Needs Review label Jun 29, 2019

phansys force-pushed the php74 branch from fcc91c4 to 43ac16d Compare June 29, 2019 23:18

phansys changed the base branch from 4.4 to 3.4 June 29, 2019 23:19

phansys force-pushed the php74 branch from 43ac16d to fab833c Compare June 30, 2019 14:05

nicolas-grekas added this to the 3.4 milestone Jun 30, 2019

nicolas-grekas requested changes Jun 30, 2019

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Needs Review labels Jun 30, 2019

phansys force-pushed the php74 branch from c197db8 to 30c8e61 Compare June 30, 2019 21:33

fabpot reviewed Jul 1, 2019

View reviewed changes

phpunit Outdated Show resolved Hide resolved

greg0ire mentioned this pull request Jul 8, 2019

[PHPUnitBridge] Mute deprecations triggered from phpunit #32443

Merged

ro0NL mentioned this pull request Jul 18, 2019

[Serializer] Add CsvEncoder tests for PHP 7.4 #32051

Merged

phansys mentioned this pull request Jul 22, 2019

[Tests] Replace setUp()/tearDown() with before()/after() #32651

Closed

1 task

This was referenced Jul 26, 2019

[CONSOLE] PHP 7.4: Trying to access array offset on value of type int #32750

Closed

[Cache] PHP 7.4 Unbinding $this of closure is deprecated #32795

Closed

PHP 7.4 - Allowed memory size exhausted in MergeExtensionConfigurationPass #32368

Closed

Allow Travis CI to build on PHP 7.4

1ca61d3

nicolas-grekas force-pushed the php74 branch from e635e82 to 1ca61d3 Compare July 31, 2019 17:00

nicolas-grekas approved these changes Jul 31, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels Jul 31, 2019

nicolas-grekas merged commit 1ca61d3 into symfony:3.4 Jul 31, 2019

phansys deleted the php74 branch July 31, 2019 17:03

nicolas-grekas mentioned this pull request Jul 31, 2019

PHP 7.4 + PHPUnit 8.2 support #32844

Closed

23 tasks

Uh oh!

Allow Travis CI to build on PHP 7.4 #32289

Allow Travis CI to build on PHP 7.4 #32289

Uh oh!

Conversation

phansys commented Jun 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tobion commented Jun 29, 2019

Uh oh!

phansys commented Jun 29, 2019

Uh oh!

nicolas-grekas left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

phansys commented Jun 30, 2019

Uh oh!

phansys commented Jun 30, 2019

Uh oh!

nicolas-grekas commented Jun 30, 2019

Uh oh!

nicolas-grekas commented Jun 30, 2019

Uh oh!

Uh oh!

greg0ire commented Jul 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phansys commented Jul 1, 2019

Uh oh!

greg0ire commented Jul 6, 2019

Uh oh!

greg0ire commented Jul 6, 2019

Uh oh!

nicolas-grekas commented Jul 8, 2019

Uh oh!

greg0ire commented Jul 8, 2019

Uh oh!

greg0ire commented Jul 8, 2019

Uh oh!

phansys commented Jul 18, 2019

Uh oh!

nicolas-grekas commented Jul 18, 2019

Uh oh!

greg0ire commented Jul 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolas-grekas commented Jul 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolas-grekas left a comment

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas commented Jul 31, 2019

Uh oh!

Uh oh!

phansys commented Jun 29, 2019 •

edited

Loading

nicolas-grekas left a comment •

edited

Loading

greg0ire commented Jul 1, 2019 •

edited

Loading

greg0ire commented Jul 19, 2019 •

edited

Loading

nicolas-grekas commented Jul 19, 2019 •

edited

Loading