[PHPUnitBridge] Mute deprecations triggered from phpunit #32443

greg0ire · 2019-07-08T18:13:24Z

Q	A
Branch?	4.3
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	n/a

Request by @nicolas-grekas here: #32289 (comment)

src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php

src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Deprecation.php

greg0ire · 2019-07-08T18:17:24Z

@phansys, please review, and maybe test?

phansys · 2019-07-10T00:35:29Z

@phansys, please review, and maybe test?

See https://travis-ci.org/symfony/symfony/jobs/556567606.

greg0ire · 2019-07-10T06:33:37Z

Thanks for this, looks like it does not work yet. I will try to make your PoC run locally and debug this :)

greg0ire · 2019-07-10T06:33:45Z

status: needs work

greg0ire · 2019-07-10T06:44:28Z

Ah wait… the way to properly test this would be do add rm -fr vendor/symfony/phpunit-bridge -fr && cp -r src/Symfony/Bridge/PhpUnit/ vendor/symfony/phpunit-bridge somewhere in the build script

greg0ire · 2019-07-10T07:08:17Z

I created my own PoC, but it does not work either… will have to investigate https://travis-ci.org/symfony/symfony/jobs/556660318

greg0ire · 2019-07-11T06:55:28Z

Ok so I have fixed most occurences of the deprecation. Some remain because of

symfony/src/Symfony/Component/Messenger/DependencyInjection/MessengerPass.php

Line 219 in 2e5a8c8

    
           throw new RuntimeException(sprintf('Invalid handler service "%s": type-hint of argument "$%s" in method "%s::__invoke()" must be a class , "%s" given.', $serviceId, $parameters[0]->getName(), $handlerClass->getName(), $type));

or because of the deprecation serialization system (I have to work on that one, I can probably reuse the originatingClass() method).

greg0ire · 2019-07-11T21:11:40Z

because of the deprecation serialization system (I have to work on that one, I can probably reuse the originatingClass() method).

Actually, I don't think I should attempt to fix that one: I don't have enough information to achieve it in a robust manner: a:4:{s:11:"deprecation";s:51:"Function ReflectionType::__toString() is deprecated";s:5:"class";s:41:"Symfony\Bridge\Twig\Tests\AppVariableTest";s:6:"method";s:14:"testGetSession";s:15:"triggering_file";s:110:"/home/travis/build/greg0ire/symfony/.phpunit/phpunit-6.5/vendor/phpunit/phpunit-mock-objects/src/Generator.php";}

The interesting part here is trigerring_file, but detecting vendor/phpunit looks fragile. Should I go for it anyway? Or should I just give up in that particular case? Please advise @nicolas-grekas

greg0ire · 2019-07-11T21:18:40Z

There are also a bunch of deprecations that don't seem to go through the bridge at all in the Debug component, I don't think I can do much about that…

nicolas-grekas · 2019-07-15T16:05:36Z

Checking for /vendor/phpunit/ (using DIRECTORY_SEPARATOR) LGTM. That's a pragmatic choice for insulated tests.

greg0ire · 2019-07-15T21:30:25Z

Done. Here is what it looks like on my PoC: https://travis-ci.org/greg0ire/symfony/jobs/559138971
The only occurences left are

when the bridge is not in use
when Symfony (in that case Messenger) is at fault.

greg0ire · 2019-07-15T21:30:43Z

Status: needs review

greg0ire · 2019-07-16T21:35:34Z

I met with Nicolas, and we established that I need to take care of the deprecations not going through the bridge error handler in the Debug component. We also established I need to make a separate PR to backport this to 3.4, where the code for the bridge is very different.

greg0ire · 2019-07-16T21:35:42Z

Status: needs work

greg0ire · 2019-07-16T21:58:00Z

Ok now we're only left with the Messenger deprecation, which should probably be fixed in another PR: https://travis-ci.org/greg0ire/symfony/jobs/559682090

Status: needs review

nicolas-grekas

thanks, let's fix the Messenger deprecation in the same PR, enough bureaucracy :)

src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Deprecation.php

src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationTest.php

greg0ire · 2019-07-17T22:15:02Z

thanks, let's fix the Messenger deprecation in the same PR, enough bureaucracy :)

Ok! Done. Here is a proof of that claim: https://travis-ci.org/greg0ire/symfony/jobs/560211283

Please review again :)

greg0ire · 2019-07-18T06:40:42Z

We also established I need to make a separate PR to backport this to 3.4, where the code for the bridge is very different.

Nicolas has realized that I actually don't need to do that PR since 3.4 is tested with the version 4 of the bridge, which will contain the fix.

A separate PR has been done regarding the Debug deprecations: #32592

As for the Messenger deprecation, the fix should stay in this PR since there is no Messenger on 3.4.

nicolas-grekas · 2019-07-18T10:47:56Z

Can you please rebase?

greg0ire · 2019-07-18T13:30:51Z

Done

nicolas-grekas · 2019-07-18T13:35:08Z

Thank you @greg0ire.

@nicolas-grekas

…greg0ire) This PR was merged into the 4.3 branch. Discussion ---------- [PHPUnitBridge] Mute deprecations triggered from phpunit | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Request by @nicolas-grekas here: #32289 (comment) Commits ------- a4ab13d Mute deprecations triggered from phpunit

carsonbot added Status: Needs Review PhpUnitBridge Bug labels Jul 8, 2019

greg0ire force-pushed the muted-deprecations branch from 430589e to 780579f Compare July 8, 2019 18:14

greg0ire commented Jul 8, 2019

View reviewed changes

src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php Outdated Show resolved Hide resolved

greg0ire commented Jul 8, 2019

View reviewed changes

src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Deprecation.php Outdated Show resolved Hide resolved

phansys mentioned this pull request Jul 10, 2019

[PHPUnitBridge] PoC for #32443 #32468

Closed

carsonbot added Status: Needs Work and removed Status: Needs Review labels Jul 10, 2019

nicolas-grekas added this to the 4.3 milestone Jul 10, 2019

greg0ire force-pushed the muted-deprecations branch 2 times, most recently from b7a96eb to a686300 Compare July 10, 2019 22:10

greg0ire force-pushed the muted-deprecations branch 2 times, most recently from b28be9f to 69ba9d0 Compare July 15, 2019 21:16

carsonbot added Status: Needs Review and removed Status: Needs Work labels Jul 15, 2019

carsonbot added Status: Needs Work and removed Status: Needs Review labels Jul 16, 2019

greg0ire force-pushed the muted-deprecations branch from 469d8be to 9ae8ffe Compare July 16, 2019 21:46

carsonbot added Status: Needs Review and removed Status: Needs Work labels Jul 16, 2019

nicolas-grekas reviewed Jul 17, 2019

View reviewed changes

greg0ire force-pushed the muted-deprecations branch 2 times, most recently from 54df46c to 8724a39 Compare July 17, 2019 22:06

nicolas-grekas approved these changes Jul 18, 2019

View reviewed changes

Mute deprecations triggered from phpunit

a4ab13d

greg0ire force-pushed the muted-deprecations branch from 8724a39 to a4ab13d Compare July 18, 2019 13:29

nicolas-grekas merged commit a4ab13d into symfony:4.3 Jul 18, 2019

phansys mentioned this pull request Jul 18, 2019

Allow Travis CI to build on PHP 7.4 #32289

Merged

fabpot mentioned this pull request Jul 28, 2019

Release v4.3.3 #32788

Merged

greg0ire deleted the muted-deprecations branch November 3, 2019 10:50

Uh oh!

[PHPUnitBridge] Mute deprecations triggered from phpunit #32443

[PHPUnitBridge] Mute deprecations triggered from phpunit #32443

Uh oh!

Conversation

greg0ire commented Jul 8, 2019

Uh oh!

Uh oh!

Uh oh!

greg0ire commented Jul 8, 2019

Uh oh!

phansys commented Jul 10, 2019

Uh oh!

greg0ire commented Jul 10, 2019

Uh oh!

greg0ire commented Jul 10, 2019

Uh oh!

greg0ire commented Jul 10, 2019

Uh oh!

greg0ire commented Jul 10, 2019

Uh oh!

greg0ire commented Jul 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greg0ire commented Jul 11, 2019

Uh oh!

greg0ire commented Jul 11, 2019

Uh oh!

nicolas-grekas commented Jul 15, 2019

Uh oh!

greg0ire commented Jul 15, 2019

Uh oh!

greg0ire commented Jul 15, 2019

Uh oh!

greg0ire commented Jul 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greg0ire commented Jul 16, 2019

Uh oh!

greg0ire commented Jul 16, 2019

Uh oh!

nicolas-grekas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greg0ire commented Jul 17, 2019

Uh oh!

greg0ire commented Jul 18, 2019

Uh oh!

nicolas-grekas commented Jul 18, 2019

Uh oh!

greg0ire commented Jul 18, 2019

Uh oh!

nicolas-grekas commented Jul 18, 2019

Uh oh!

Uh oh!

greg0ire commented Jul 11, 2019 •

edited

Loading

greg0ire commented Jul 16, 2019 •

edited

Loading