Minor updates in the new Welcome page #33613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Sep 17, 2019
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Sep 17, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Minor updates in the new Welcome page | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - After #33510 was merged, there were some concerns about the warning message in the "Welcome Page". It's too low on the page, so it's easy to oversee it. So, in this PR we propose to make the warning message way more visible and other minor tweaks. This is how it'd look on a smartphone and on a desktop:  Commits ------- 4517319 Minor updates in the new Welcome page
yceruto
added a commit
that referenced
this pull request
Sep 23, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Minor tweaks to the Welcome Page | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Sorry, I'm late on #33613 and #33614 but I realized 3 minor visual issues: * the background color of the warning message for consistency should be `$lightColor()` and imho a little bit smaller. * the check icon has a very wide margin in relation to the edge of the rounded box:  vs  * and the resources (doc links) on wide screens have a very small space between them. I've also removed some useless css classes (footer). | before | after | | --- | --- | |  |  | tested on Chrome and Firefox. Commits ------- 8484378 Minor tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #33510 was merged, there were some concerns about the warning message in the "Welcome Page". It's too low on the page, so it's easy to oversee it.
So, in this PR we propose to make the warning message way more visible and other minor tweaks. This is how it'd look on a smartphone and on a desktop: