Minor tweaks to the Welcome Page #33660
Conversation
|
The white background for the warning was on purpose to make it more visible and stand out in the page. The separation between icons on wide screen can be made wider ... but I think it's too wide now :( |
yceruto
force-pushed
the
welcome_page
branch
from
c548e89 to
8484378
Compare
|
Hi @javiereguiluz, I'm sorry I didn't discuss it earlier.
I agree with that, and I think still it's super visible at top of the page and even has a large font size, I don't think making it consistent with the light color
I've added the |
There was a problem hiding this comment.
Thanks for making some tweaks.
About the warning background, you are right that the difference is not visible to most users.
About the icons, I saw that you increased the max-width. I thin kit's a good solution to let them breath ... without displaying them visually unconnected.
Thanks!
This PR was merged into the 4.4 branch. Discussion ---------- Minor tweaks to the Welcome Page | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Sorry, I'm late on #33613 and #33614 but I realized 3 minor visual issues: * the background color of the warning message for consistency should be `$lightColor()` and imho a little bit smaller. * the check icon has a very wide margin in relation to the edge of the rounded box:  vs  * and the resources (doc links) on wide screens have a very small space between them. I've also removed some useless css classes (footer). | before | after | | --- | --- | |  |  | tested on Chrome and Firefox. Commits ------- 8484378 Minor tweaks
Sorry, I'm late on #33613 and #33614 but I realized 3 minor visual issues:
$lightColor()and imho a little bit smaller.I've also removed some useless css classes (footer).
tested on Chrome and Firefox.