Skip to content

[Notifier] Add Contact Everyone Bridge #46395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2022
Merged

[Notifier] Add Contact Everyone Bridge #46395

merged 1 commit into from
Jun 25, 2022

Conversation

franckranaivo
Copy link
Contributor

@franckranaivo franckranaivo commented May 18, 2022 •
edited
Loading

Q A
Branch? 6.2
Bug fix? no
New feature? yes
Deprecations? no
License MIT
Doc PR TODO

Add Contact Everyone Bridge by Orange Business.

This bridge uses the light version of the api which allows SMS to be sent individually.

@franckranaivo franckranaivo requested a review from OskarStark as a code owner May 18, 2022 15:22
@carsonbot carsonbot added this to the 6.1 milestone May 18, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

stof
stof requested changes May 18, 2022
View reviewed changes
@franckranaivo franckranaivo force-pushed the contact-everyone-notifier branch from a805b4c to 40ef71f Compare May 18, 2022 16:40
@OskarStark OskarStark modified the milestones: 6.1, 6.2 May 18, 2022
@franckranaivo franckranaivo force-pushed the contact-everyone-notifier branch 2 times, most recently from 868cf5a to 723ad78 Compare May 19, 2022 13:12
@franckranaivo franckranaivo force-pushed the contact-everyone-notifier branch from 723ad78 to 89b2981 Compare May 19, 2022 14:28
@OskarStark OskarStark requested a review from stof May 19, 2022 20:32
OskarStark
OskarStark approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please open a PR on symfony-docs repo? Thanks

@OskarStark
Copy link
Contributor

@fabpot is it possible to to add this exception to fabbot.io?
CleanShot 2022-05-19 at 22 33 36@2x

@wouterj wouterj mentioned this pull request May 20, 2022
Closed
@OskarStark
Copy link
Contributor

friendly ping @fabpot

fabpot
fabpot requested changes Jun 24, 2022
View reviewed changes
src/Symfony/Component/Notifier/Bridge/ContactEveryone/ContactEveryoneTransport.php Outdated
{
$dsn = sprintf('contact-everyone://%s', $this->getEndpoint());

if (null !== $this->diffusionName) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (null !== $this->diffusionName) {
if ($this->diffusionName) {

src/Symfony/Component/Notifier/Bridge/ContactEveryone/ContactEveryoneTransport.php Outdated
$dsn .= sprintf('?diffusionname=%s', $this->diffusionName);
}

if (null !== $this->category) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (null !== $this->category) {
if ($this->category) {

src/Symfony/Component/Notifier/Bridge/ContactEveryone/README.md Outdated
- `DIFFUSION_NAME` (optional) allows you to define the label of the diffusion that will be displayed in the event logs.
- `CATEGORY` (optional) allows you to define the label of the category that will be displayed in the event logs.

This bridge uses the light version of Contact Everyone api.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This bridge uses the light version of Contact Everyone api.
This bridge uses the light version of Contact Everyone API.

src/Symfony/Component/Notifier/Bridge/ContactEveryone/README.md Outdated
```

where:
- `TOKEN` is your Contact Everyone api token
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `TOKEN` is your Contact Everyone api token
- `TOKEN` is your Contact Everyone API token

@franckranaivo franckranaivo force-pushed the contact-everyone-notifier branch from 9e64c34 to 7f26839 Compare June 24, 2022 16:33
@fabpot
Copy link
Member

fabpot commented Jun 25, 2022

Thank you @franckranaivo.

@fabpot fabpot force-pushed the contact-everyone-notifier branch from 7f26839 to 539d2a1 Compare June 25, 2022 07:11
@fabpot fabpot merged commit 2a2d5b3 into symfony:6.2 Jun 25, 2022
@fabpot fabpot mentioned this pull request Jun 25, 2022
Closed
@fabpot
Copy link
Member

fabpot commented Jun 25, 2022

@franckranaivo Can you submit a PR for a recipe? Something like this: https://github.com/symfony/recipes/pull/1102/files
And a PR for the docs?
Thank you.

@franckranaivo
Copy link
Contributor Author

Sure. Thank you @fabpot for symfony/symfony-docs#16915 for the PR Docs.

@fabpot fabpot mentioned this pull request Oct 24, 2022
Merged
@franckranaivo franckranaivo deleted the contact-everyone-notifier branch March 22, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

@stof stof Awaiting requested review from stof

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
5 participants
@franckranaivo @carsonbot @OskarStark @fabpot @stof