Skip to content

[WIP] Contact everyone doc #16816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

franckranaivo
Copy link
Contributor

No description provided.

wouterj and others added 6 commits May 16, 2022 21:48
…cript config (jmsche)

This PR was merged into the 5.4 branch.

Discussion
----------

[Frontend] Add a note about stimulusFetch & TypeScript config

Just a note about using `stimulusFetch` in Stimulus controllers while writing them with TypeScript.

Commits
-------

64c9936 [Frontend] Add a note about stimulusFetch & TypeScript config
* 5.4:
  [Frontend] Add a note about stimulusFetch & TypeScript config
* 6.0:
  [Frontend] Add a note about stimulusFetch & TypeScript config
This PR was merged into the 6.1 branch.

Discussion
----------

[HtmlSanitizer] Document the new component

Fixes symfony#16332, fixes symfony#16716, fixes symfony#16804

A first start with the documentation for the new HTML sanitizer component. I'm using the same style as we did in the HttpClient documentation, as I think that worked pretty well.

cc `@tgalopin`

Commits
-------

5f3cfeb [HTML Sanitizer] Write documentation
@carsonbot
Copy link
Collaborator

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 4.4, 5.4, 6.0, 6.1.

Cheers!

Carsonbot

@franckranaivo franckranaivo marked this pull request as draft May 20, 2022 15:25
@javiereguiluz
Copy link
Member

javiereguiluz commented May 20, 2022

Closing because the contents of this pull request look wrong and the title gives spam vibes.

@franckranaivo if your pull request is legit, please tell us and we'll reopen. Thanks!

@wouterj
Copy link
Member

wouterj commented May 20, 2022

I think it was meant as a doc PR for symfony/symfony#46395 (the contact everyone notifier bridge), but something went wrong :)

@javiereguiluz
Copy link
Member

javiereguiluz commented May 20, 2022

Ah. Ok. Let's reopen then. Sorry @franckranaivo 🙏 . If you cannot remove the unrelated commits from this PR we can close it again to create a new PR. If you need any help, please ask us. Thanks!

@javiereguiluz javiereguiluz reopened this May 20, 2022
@franckranaivo
Copy link
Contributor Author

Ah yes it was meant for symfony/symfony#46395 as i was requested to create a PR for the docs. Actually I created one for 6.2, but @carsonbot said that it was not maintained anymore. Then I switched to 6.1 and saw other commits after that.
Should I close maybe this one and create another PR from 6.2 ? @javiereguiluz .
I apologize if I did wrong as it is my first PR on docs also.

@wouterj
Copy link
Member

wouterj commented May 23, 2022

No worries! For some reason, your commit appears to be lost (none of the 6 commits listed in this PR appear to be yours). So yes, I think the only way to fix this is to try to submit a new one (for the 6.2 branch).

Actually I created one for 6.2, but @carsonbot said that it was not maintained anymore. Then I switched to 6.1 and saw other commits after that.

Ah yeah. Carsonbot has a little issue with dev branches created before entering development phase (the 6.2 development phase starts at June 1st, but we created the branch in advance to prepare the 6.1 release). 6.2 is the correct branch for the PR :)

@franckranaivo franckranaivo deleted the contact-everyone-doc branch May 23, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants