Skip to content

[Mime] Add PHP mimetype "text/x-php" extension "php" #51141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

guillaume-a
Copy link
Contributor

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #51124
License MIT

Regarding the issue #51124, Added the php extension to the MAP for the mime type.

@fabpot
Copy link
Member

fabpot commented Jul 31, 2023

We don't add specific mimetypes as we are relying on upstream sources.
You can either register it yourself or contribute it upstream.

@fabpot fabpot closed this Jul 31, 2023
@guillaume-a
Copy link
Contributor Author

Oh I get it.
I just read the comment about Ressources/bin/update_mime_types.php.php script. (missed that)

Maybe it's time to run it and update all map ?
But it will not fix @valorin issue because text/x-php is not referenced in both sources.

I totally understand my PR is invalid (no problem with that) but I don't know what to do to fix it tho.

@stof
Copy link
Member

stof commented Jul 31, 2023

You need to submit this mimetype to one of those upstream sources

@fabpot
Copy link
Member

fabpot commented Jul 31, 2023

See #51191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants